Re: [OpenWrt-Devel] [RFC v2] [zynq] Add new target zynq

2016-01-19 Thread Jason Wu
On 19/01/2016 7:13 PM, Felix Fietkau wrote: On 2016-01-19 10:05, John Crispin wrote: On 19/01/2016 09:59, Felix Fietkau wrote: If you remove the zynq.sh, the variable will always be empty. So you can just do: case "$(cat /tmp/sysinfo/board_name)" in ... esac - Felix dont we have

Re: [OpenWrt-Devel] [RFC v2] [zynq] Add new target zynq

2016-01-19 Thread Felix Fietkau
On 2016-01-19 10:05, John Crispin wrote: > > > On 19/01/2016 09:59, Felix Fietkau wrote: >> If you remove the zynq.sh, the variable will always be empty. So you can >> just do: >> case "$(cat /tmp/sysinfo/board_name)" in >> ... >> esac >> >> - Felix > > dont we have a unified helper for th

Re: [OpenWrt-Devel] [RFC v2] [zynq] Add new target zynq

2016-01-19 Thread John Crispin
On 19/01/2016 09:59, Felix Fietkau wrote: > If you remove the zynq.sh, the variable will always be empty. So you can > just do: > case "$(cat /tmp/sysinfo/board_name)" in > ... > esac > > - Felix dont we have a unified helper for this since jows cleanup 2 weeks ago ? _

Re: [OpenWrt-Devel] [RFC v2] [zynq] Add new target zynq

2016-01-19 Thread Felix Fietkau
On 2016-01-19 08:46, Jason Wu wrote: > Hi Felix, > > Thanks for reviewing the patch. please see my reply inline. > >> If you adjust your other scripts to be able to deal with names like >> "xlnx,zynq-zc702", you can drop this script and let the default sysinfo >> script take care of things. > So

Re: [OpenWrt-Devel] [RFC v2] [zynq] Add new target zynq

2016-01-18 Thread Jason Wu
Hi Felix, Thanks for reviewing the patch. please see my reply inline. On 19/01/2016 12:09 AM, Felix Fietkau wrote: On 2016-01-18 14:36, Jason Wu wrote: Add support for Xilinx ZC702 Dev board Zynq target is using 4.4 kernel and mainline 2016.1 u-boot. I symbolic linked /init with /sbin/init,

Re: [OpenWrt-Devel] [RFC v2] [zynq] Add new target zynq

2016-01-18 Thread Felix Fietkau
On 2016-01-18 14:36, Jason Wu wrote: > Add support for Xilinx ZC702 Dev board > > Zynq target is using 4.4 kernel and mainline 2016.1 u-boot. > > I symbolic linked /init with /sbin/init, I am sure this is > acceptable from OpenWrt (although this can be workaround with > rdinit="/sbin/init" in boo

[OpenWrt-Devel] [RFC v2] [zynq] Add new target zynq

2016-01-18 Thread Jason Wu
Add support for Xilinx ZC702 Dev board Zynq target is using 4.4 kernel and mainline 2016.1 u-boot. I symbolic linked /init with /sbin/init, I am sure this is acceptable from OpenWrt (although this can be workaround with rdinit="/sbin/init" in bootargs but requires DTS modification). Patch is tes