Re: [OpenWrt-Devel] [RFC][PATCH] broadcom-wl: read channel using wlc on detect

2013-04-30 Thread Jo-Philipp Wich
> IMHO the logic should be: > > if wl $WIFIDEV bands | grep -q "802.11a" ; then > channel=36 > else > channel=1 > fi The logic should be: channel=11 if wl $WIFIDEV bands | grep -q "802.11a" ; then channel=36 fi This brings it in line with mac80211 (package/mac80211/files/lib/wi

Re: [OpenWrt-Devel] [RFC][PATCH] broadcom-wl: read channel using wlc on detect

2013-04-30 Thread Bastian Bittorf
* Rafał Miłecki [30.04.2013 13:14]: > > Can you point me to some guidelines or sth? I had no idea about that. > > Is that documented anywhere? > > I checked http://wiki.openwrt.org/doc/uci/wireless and it specifies > "auto" as default value for "channel", but that's for station mode > only. IMHO

Re: [OpenWrt-Devel] [RFC][PATCH] broadcom-wl: read channel using wlc on detect

2013-04-30 Thread Rafał Miłecki
2013/4/29 Rafał Miłecki : > 2013/4/29 Jo-Philipp Wich : >> On 18.04.2013 11:17, Rafał Miłecki wrote: >>> Hardcoding channel number to 11 is a bad idea, it may be even not >>> available on some devices. If there are two single-band radios, the >>> one for 5GHz doesn't have 11 channel. >> >> That pat

Re: [OpenWrt-Devel] [RFC][PATCH] broadcom-wl: read channel using wlc on detect

2013-04-29 Thread David Goodenough
On Monday 29 Apr 2013, Jo-Philipp Wich wrote: > On 18.04.2013 11:17, Rafał Miłecki wrote: > > Hardcoding channel number to 11 is a bad idea, it may be even not > > available on some devices. If there are two single-band radios, the > > one for 5GHz doesn't have 11 channel. > > That patch makes the

Re: [OpenWrt-Devel] [RFC][PATCH] broadcom-wl: read channel using wlc on detect

2013-04-29 Thread Rafał Miłecki
2013/4/29 Jo-Philipp Wich : > On 18.04.2013 11:17, Rafał Miłecki wrote: >> Hardcoding channel number to 11 is a bad idea, it may be even not >> available on some devices. If there are two single-band radios, the >> one for 5GHz doesn't have 11 channel. > > That patch makes the Broadcom default wire

Re: [OpenWrt-Devel] [RFC][PATCH] broadcom-wl: read channel using wlc on detect

2013-04-29 Thread Jo-Philipp Wich
On 18.04.2013 11:17, Rafał Miłecki wrote: > Hardcoding channel number to 11 is a bad idea, it may be even not > available on some devices. If there are two single-band radios, the > one for 5GHz doesn't have 11 channel. That patch makes the Broadcom default wireless config generation inconsistent

[OpenWrt-Devel] [RFC][PATCH] broadcom-wl: read channel using wlc on detect

2013-04-18 Thread Rafał Miłecki
Hardcoding channel number to 11 is a bad idea, it may be even not available on some devices. If there are two single-band radios, the one for 5GHz doesn't have 11 channel. Signed-off-by: Rafał Miłecki --- package/broadcom-wl/files/lib/wifi/broadcom.sh |5 - 1 file changed, 4 insertions(+