Re: [OpenWrt-Devel] [PATCHv2] scripts/feeds: observe -p flag for preferential feeds

2015-06-23 Thread Karl Palsson
Karl Palsson wrote: > > John Crispin wrote: > > > On 27/05/2015 18:03, Karl Palsson wrote: > > > > + my $this_feed_target = lookup_target($feed, $name); > > > > + $this_feed_target and do { > > > > > > how about just calling it $target ? > > > > Because even though the method is "l

Re: [OpenWrt-Devel] [PATCHv2] scripts/feeds: observe -p flag for preferential feeds

2015-06-09 Thread Karl Palsson
Karl Palsson wrote: > > John Crispin wrote: > > On 27/05/2015 18:03, Karl Palsson wrote: > > > + my $this_feed_target = lookup_target($feed, $name); > > > + $this_feed_target and do { > > > > how about just calling it $target ? > > Because even though the method is "lookup_target" it actually

Re: [OpenWrt-Devel] [PATCHv2] scripts/feeds: observe -p flag for preferential feeds

2015-06-01 Thread Karl Palsson
John Crispin wrote: > On 27/05/2015 18:03, Karl Palsson wrote: > > + my $this_feed_target = lookup_target($feed, $name); > > + $this_feed_target and do { > > how about just calling it $target ? Because even though the method is "lookup_target" it actually returns a feed for the target $name

Re: [OpenWrt-Devel] [PATCHv2] scripts/feeds: observe -p flag for preferential feeds

2015-05-31 Thread John Crispin
On 27/05/2015 18:03, Karl Palsson wrote: > + my $this_feed_target = lookup_target($feed, $name); > + $this_feed_target and do { how about just calling it $target ? ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openw

[OpenWrt-Devel] [PATCHv2] scripts/feeds: observe -p flag for preferential feeds

2015-05-27 Thread Karl Palsson
From: Karl Palsson lookup_target was trampling the $feed variable, resulting in the -p flag no longer preferentially installing from the named feed. Make sure to use a local variable for this instead. Signed-off-by: Karl Palsson --- Changes since v1: Make sure to not just trample a global var