Re: [OpenWrt-Devel] [PATCH v2] cns3xxx: add nol2x0 cmdline to disable l2x0 cache

2012-10-30 Thread Luka Perkov
On Tue, Oct 30, 2012 at 09:03:29AM -0700, Tim Harvey wrote: > I'm not finding documentation but it looks to me like the return 1 > signifies that you have consumed that param and it shouldn't be sent to > other init functions. Like you I looked at other code and found them to > all return 1 so did

Re: [OpenWrt-Devel] [PATCH v2] cns3xxx: add nol2x0 cmdline to disable l2x0 cache

2012-10-30 Thread Tim Harvey
Luka, I'm not finding documentation but it looks to me like the return 1 signifies that you have consumed that param and it shouldn't be sent to other init functions. Like you I looked at other code and found them to all return 1 so did the same. Personally the right way to disable L2X0 is to ju

Re: [OpenWrt-Devel] [PATCH v2] cns3xxx: add nol2x0 cmdline to disable l2x0 cache

2012-10-30 Thread Luka Perkov
On Mon, Oct 29, 2012 at 03:03:55PM -0700, Tim Harvey wrote: > L2 cache via L2X0 cache controller available on some ARM boards can > provide a performance boost in some situations but decrease performance > in others. This adds a kernel cmdline to disable L2X0 for the Laguna > product family. > >

[OpenWrt-Devel] [PATCH v2] cns3xxx: add nol2x0 cmdline to disable l2x0 cache

2012-10-29 Thread Tim Harvey
L2 cache via L2X0 cache controller available on some ARM boards can provide a performance boost in some situations but decrease performance in others. This adds a kernel cmdline to disable L2X0 for the Laguna product family. Signed-off-by: Tim Harvey --- .../patches-3.3/480-laguna_l2cache_cmdli