Re: [OpenWrt-Devel] [PATCH 6/7] base-files/functions.sh: do not iterate over ls

2020-01-18 Thread mail
Hi, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Rosen Penev > Sent: Freitag, 17. Januar 2020 05:44 > To: openwrt-devel@lists.openwrt.org > Subject: [OpenWrt-Devel] [PATCH 6/7] base-files/functions.sh: do not

[OpenWrt-Devel] [PATCH 6/7] base-files/functions.sh: do not iterate over ls

2020-01-16 Thread Rosen Penev
It does word splitting and glob expansion, which is undesirable. https://github.com/koalaman/shellcheck/wiki/SC2045 Signed-off-by: Rosen Penev --- package/base-files/files/lib/functions.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package/base-files/files/lib/functio