Re: [OpenWrt-Devel] [PATCH 2/3] rules.mk: replace iremap when using GCC 8

2018-06-24 Thread Yousong Zhou
On Fri, 22 Jun 2018 at 19:21, Syrone Wong wrote: > > Hi, > > LGTM. Any documentation on the hidden config symbols? do not top post please. kconfig symbols will be hidden when they have no title. basically all symbols in Config.version are hidden. yousong > > > Best Regards, >

Re: [OpenWrt-Devel] [PATCH 2/3] rules.mk: replace iremap when using GCC 8

2018-06-22 Thread Syrone Wong
Hi, LGTM. Any documentation on the hidden config symbols? Best Regards, Syrone Wong On Fri, Jun 22, 2018 at 5:00 PM, Yousong Zhou wrote: > On Fri, 22 Jun 2018 at 08:22, Syrone Wong wrote: >> >> HI, >> >> I'm not sure whether it's the correct way to deal with the flag. When >> we add GCC 9 in

Re: [OpenWrt-Devel] [PATCH 2/3] rules.mk: replace iremap when using GCC 8

2018-06-22 Thread Yousong Zhou
On Fri, 22 Jun 2018 at 08:22, Syrone Wong wrote: > > HI, > > I'm not sure whether it's the correct way to deal with the flag. When > we add GCC 9 in the future, we have to remember to apply this dirty > overwrite hack as well. > Please feel free to share more elegant ways. How about adding a hidd

Re: [OpenWrt-Devel] [PATCH 2/3] rules.mk: replace iremap when using GCC 8

2018-06-21 Thread Syrone Wong
HI, I'm not sure whether it's the correct way to deal with the flag. When we add GCC 9 in the future, we have to remember to apply this dirty overwrite hack as well. Please feel free to share more elegant ways. Best Regards, Syrone Wong On Thu, Jun 21, 2018 at 11:08 PM, wrote: > From: Syrone

[OpenWrt-Devel] [PATCH 2/3] rules.mk: replace iremap when using GCC 8

2018-06-21 Thread wong . syrone
From: Syrone Wong The original -iremap is replaced by -fmacro-prefix-map in GCC 8 Signed-off-by: Syrone Wong --- rules.mk | 4 1 file changed, 4 insertions(+) diff --git a/rules.mk b/rules.mk index a97b2d2155..8eb8e21a7e 100644 --- a/rules.mk +++ b/rules.mk @@ -141,6 +141,10 @@ endif