Re: [OpenWrt-Devel] [PATCH] wireguard: do not add host-dependencies if fwmark is set

2019-03-26 Thread Jo-Philipp Wich
HI, I too think that making host route installation dependent on the fwmark option is not intuitive. > So maybe we can add an explicit option 'nohostroute' instead of making > it depend on 'fwmark'? A "nohostroute" (I'd prefer "peerroute" with default "1") would make sense imho. It should also b

Re: [OpenWrt-Devel] [PATCH] wireguard: do not add host-dependencies if fwmark is set

2019-03-20 Thread Daniel Golle
On Wed, Mar 20, 2019 at 04:31:25PM +0800, Yousong Zhou wrote: > On Tue, 19 Mar 2019 at 23:53, Daniel Golle wrote: > > > > The 'fwmark' option is used to define routing traffic to > > wireguard endpoints to go through specific routing tables. > > In that case it doesn't make sense to setup routes f

Re: [OpenWrt-Devel] [PATCH] wireguard: do not add host-dependencies if fwmark is set

2019-03-20 Thread Yousong Zhou
On Tue, 19 Mar 2019 at 23:53, Daniel Golle wrote: > > The 'fwmark' option is used to define routing traffic to > wireguard endpoints to go through specific routing tables. > In that case it doesn't make sense to setup routes for > host-dependencies in the 'main' table, so skip setting host > depen

[OpenWrt-Devel] [PATCH] wireguard: do not add host-dependencies if fwmark is set

2019-03-19 Thread Daniel Golle
The 'fwmark' option is used to define routing traffic to wireguard endpoints to go through specific routing tables. In that case it doesn't make sense to setup routes for host-dependencies in the 'main' table, so skip setting host dependencies if 'fwmark' is set. Signed-off-by: Daniel Golle ---