> "John" == John Crispin writes:
John> narf ... fat fingered it ... sorry you need to send a v3
Sent 9 days ago. I think patch 1/3 is fairly uncontroversial, as it
fixes plain old brokenness.
Depending on patch 2/3 and the choice of key code, patch 3/3 might be
irrelevant, assuming
On 17/09/2014 09:42, Russell Senior wrote:
>> "John" == John Crispin writes:
>
> John> On 17/09/2014 09:24, Russell Senior wrote:
>>> It also enables GPIO control of the second GPIO controller, in
>>> rt5350.dtsi, but does not use it.
>
> John> that is why it is not enabled by default :)
narf ... fat fingered it ... sorry you need to send a v3
/me gets coffee
On 17/09/2014 09:42, John Crispin wrote:
>
> On 17/09/2014 09:39, John Crispin wrote:
>> On 17/09/2014 09:24, Russell Senior wrote:
>>> diff --git
>>> a/package/kernel/gpio-button-hotplug/src/gpio-button-hotplug.c
> "John" == John Crispin writes:
John> On 17/09/2014 09:24, Russell Senior wrote:
>> It also enables GPIO control of the second GPIO controller, in
>> rt5350.dtsi, but does not use it.
John> that is why it is not enabled by default :)
It could be used, which I did while testing. I don't un
On 17/09/2014 09:39, John Crispin wrote:
> On 17/09/2014 09:24, Russell Senior wrote:
>> diff --git a/package/kernel/gpio-button-hotplug/src/gpio-button-hotplug.c
>> b/package/kernel/gpio-button-hotplug/src/gpio-button-hotplug.c
>> index c997e35..891dd96 100644
>> --- a/package/kernel/gpio-button
On 17/09/2014 09:24, Russell Senior wrote:
> diff --git a/package/kernel/gpio-button-hotplug/src/gpio-button-hotplug.c
> b/package/kernel/gpio-button-hotplug/src/gpio-button-hotplug.c
> index c997e35..891dd96 100644
> --- a/package/kernel/gpio-button-hotplug/src/gpio-button-hotplug.c
> +++ b/pack
On 17/09/2014 09:24, Russell Senior wrote:
> It also enables GPIO control of the second GPIO controller, in
> rt5350.dtsi, but does not use it.
that is why it is not enabled by default :)
please resend without the change to rt5350.dtsi
John
Revert some brain damage. The rx and tx LEDs on the eval board are
not connected to the CPU, but to the FTDI chip instead. Therefore,
they are not and cannot be under GPIO control. The LINK_0, LINK_1
LEDs are configured to be driven by the switch, and are not under GPIO
control either, though t
