Re: [OpenWrt-Devel] [PATCH] libfstools: Output error in case of loop blkdev failure

2019-03-27 Thread Petr Štetiar
Jo-Philipp Wich [2019-03-27 08:05:50]: Hi, > I suggest to rephrase the subject to something like "print error in > case". I kept reading "output error" and wondered what went wrong with > the output. Good point. > > - if (!p->loop_name[0] && rootdisk_create_loop(p) != 0) > > + if (!p->loop

Re: [OpenWrt-Devel] [PATCH] libfstools: Output error in case of loop blkdev failure

2019-03-27 Thread Jo-Philipp Wich
Hi Petr, I suggest to rephrase the subject to something like "print error in case". I kept reading "output error" and wondered what went wrong with the output. > It took me quite some time today(while fixing squashfs+overlay on > armvirt) to find out, that I was missing support for loop block dev

[OpenWrt-Devel] [PATCH] libfstools: Output error in case of loop blkdev failure

2019-03-26 Thread Petr Štetiar
It took me quite some time today(while fixing squashfs+overlay on armvirt) to find out, that I was missing support for loop block device in kernel, so I'm adding error message which might be helpful for someone else in the future as well. Signed-off-by: Petr Štetiar --- libfstools/rootdisk.c | 4