Re: [OpenWrt-Devel] [PATCH] lantiq: various fixes to the extract.sh script

2011-02-28 Thread edgar . soldin
On 28.02.2011 18:26, Luca Olivetti wrote: > [ ! -f ${DIR}decode_ifx_fw -a -f ${DIR}ifxmips_fw_decodev2.tar.bz2 ] These will break if the path contains spaces. Always enclose pathes in double quotes if you can't be sure that they never will include spaces. This is also true for the other places w

[OpenWrt-Devel] [PATCH] lantiq: various fixes to the extract.sh script

2011-02-28 Thread Luca Olivetti
Attached is a patch to fix extract.sh: - first condition, this is shell, not C ("&&" -> "-a") - second condition: logic reversed (use decode_ifx_fw if it exists, doesn't make sense to use it if it doesn't exist) - dsl_a and dsl_b were reversed (I think that dsl1->dsl_a, dsl2->dsl_b, if that is