Re: [OpenWrt-Devel] [PATCH] generic: spi-nor: rework broken-flash-reset

2020-04-08 Thread Chuanhong Guo
Hi! On Thu, Apr 9, 2020 at 1:02 AM Paul Fertser wrote: > Probably a naive question, but does this have any measurable > performance impact? It will have performance impact. There are two extra function call for every mtd operation. > In any case making reboots more reliable is worth it. I also

Re: [OpenWrt-Devel] [PATCH] generic: spi-nor: rework broken-flash-reset

2020-04-08 Thread Paul Fertser
Hello, On Mon, Apr 06, 2020 at 07:44:28PM +0800, Chuanhong Guo wrote: > Instead of resetting flash to 3B address on remove hook, this > implementation only enters 4B mode when needed, which prevents more > unexpected reboot stuck. Probably a naive question, but does this have any measurable perfo

[OpenWrt-Devel] [PATCH] generic: spi-nor: rework broken-flash-reset

2020-04-06 Thread Chuanhong Guo
Instead of resetting flash to 3B address on remove hook, this implementation only enters 4B mode when needed, which prevents more unexpected reboot stuck. This implementation makes it only break when a kernel panic happens during flash operation on 16M+ areas. Also silent broken-flash-reset warning