Re: [OpenWrt-Devel] [PATCH] fix madwifi crash in sc_cal_ch timer

2009-09-23 Thread Linus Lüssing
Yepp Felix, that one fixes ticket #5821 too, can't reproduce that bug with this patch either. Thanks you two. Cheers, Linus signature.asc Description: Digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwr

Re: [OpenWrt-Devel] [PATCH] fix madwifi crash in sc_cal_ch timer

2009-09-23 Thread Felix Fietkau
Marek Lindner wrote: > On Thursday 17 September 2009 02:19:57 Felix Fietkau wrote: >> This part is actually wrong. It looks to me as if this 'fixes' a race >> condition by disabling calibration altogether. > > I appreciate the feedback but I'm not sure I can follow you here. > > The state of the

Re: [OpenWrt-Devel] [PATCH] fix madwifi crash in sc_cal_ch timer

2009-09-20 Thread Linus Lüssing
This patch fixes ticket #5821 for me (though I don't understand why it does so). I've compiled the exact same firmware, except one time with and one time without this patch - I'm not able to reproduce the bug anymore with it. Cheers, Linus signature.asc Description: Digital signature ___

Re: [OpenWrt-Devel] [PATCH] fix madwifi crash in sc_cal_ch timer

2009-09-17 Thread Marek Lindner
On Thursday 17 September 2009 02:19:57 Felix Fietkau wrote: > This part is actually wrong. It looks to me as if this 'fixes' a race > condition by disabling calibration altogether. I appreciate the feedback but I'm not sure I can follow you here. The state of the calibration timer is modified in

Re: [OpenWrt-Devel] [PATCH] fix madwifi crash in sc_cal_ch timer

2009-09-16 Thread Felix Fietkau
Marek Lindner wrote: > This patch fixes two timer race conditions in the madwifi driver that > ultimately lead to a crash within the madwifi interrupt handler (ath_intr), > especially while fiddling with madwifi interfaces in bridged setups. > > I gave this patch to a bunch of people to test and

[OpenWrt-Devel] [PATCH] fix madwifi crash in sc_cal_ch timer

2009-09-15 Thread Marek Lindner
This patch fixes two timer race conditions in the madwifi driver that ultimately lead to a crash within the madwifi interrupt handler (ath_intr), especially while fiddling with madwifi interfaces in bridged setups. I gave this patch to a bunch of people to test and all of them came back saying