Re: [OpenWrt-Devel] [PATCH] bgmac - add support for unaligned addressing

2013-03-01 Thread Tijs Van Buggenhout
On Friday 01 March 2013 10:56:33 Tijs Van Buggenhout wrote: > On Thursday 28 February 2013 20:06:49 Hauke Mehrtens wrote: > > Hi, > > > > I haven't tested your patch I have just some comments. In general it > > looks good to me. > > Would be nice if it could be tested for both types.. I'm pretty

Re: [OpenWrt-Devel] [PATCH] bgmac - add support for unaligned addressing

2013-03-01 Thread Tijs Van Buggenhout
On Thursday 28 February 2013 20:06:49 Hauke Mehrtens wrote: > Hi, > > I haven't tested your patch I have just some comments. In general it > looks good to me. Would be nice if it could be tested for both types.. I'm pretty sure by now it's working okay for unaligned addressing, but have only one

Re: [OpenWrt-Devel] [PATCH] bgmac - add support for unaligned addressing

2013-02-28 Thread Hauke Mehrtens
Hi, I haven't tested your patch I have just some comments. In general it looks good to me. On 02/25/2013 10:18 PM, Tijs Van Buggenhout wrote: >> Signed-off-by: Tijs Van Buggenhout (t...@able.be) >>> >>> Your whole patch is malformed, there are extra line breaks and tabs >>> were eaten by you

Re: [OpenWrt-Devel] [PATCH] bgmac - add support for unaligned addressing

2013-02-25 Thread Tijs Van Buggenhout
On Monday 25 February 2013 20:35:23 Tijs Van Buggenhout wrote: > On Monday 25 February 2013 18:51:53 Rafał Miłecki wrote: > > 2013/2/25 Tijs Van Buggenhout : > > > I opted to introduce a CONFIG_BGMAC_UNALIGNED_ADDRESSING macro to > > > introduce > > > the changes to support unaligned addressing for

Re: [OpenWrt-Devel] [PATCH] bgmac - add support for unaligned addressing

2013-02-25 Thread Tijs Van Buggenhout
On Monday 25 February 2013 18:51:53 Rafał Miłecki wrote: > 2013/2/25 Tijs Van Buggenhout : > > I opted to introduce a CONFIG_BGMAC_UNALIGNED_ADDRESSING macro to > > introduce > > the changes to support unaligned addressing for the bgmac driver (it does > > add some extra bytes in bgmac_dma_ring str

Re: [OpenWrt-Devel] [PATCH] bgmac - add support for unaligned addressing

2013-02-25 Thread Rafał Miłecki
2013/2/25 Tijs Van Buggenhout : > I opted to introduce a CONFIG_BGMAC_UNALIGNED_ADDRESSING macro to introduce > the changes to support unaligned addressing for the bgmac driver (it does add > some extra bytes in bgmac_dma_ring struct). This could be an option in Kconfig > (not yet in patch), but fo

[OpenWrt-Devel] [PATCH] bgmac - add support for unaligned addressing

2013-02-25 Thread Tijs Van Buggenhout
This is a proposal for target/linux/brcm47xx/patches-3.6/770-bgmac-unaligned- addressing.patch, which adds support for DMA unaligned addressing in bgmac driver (needed for e.g. linksys e3200 devices). >From analysing the 'Generic Broadcom Home Networking Division (HND) DMA module' (hnddma.{c,h})