Re: [OpenWrt-Devel] [PATCH] base-files: fix generating network configuration

2016-01-02 Thread Yousong Zhou
Hi, On 31 December 2015 at 20:33, Roman Yeryomin wrote: > On 30 December 2015 at 14:32, Yousong Zhou wrote: >> On 30 December 2015 at 20:12, Jo-Philipp Wich wrote: >>> Hi Yousong. >>> >>> NAK - thats by design. If a network config is present then there is no >>> point in regenerating it. >>> >>

Re: [OpenWrt-Devel] [PATCH] base-files: fix generating network configuration

2015-12-31 Thread Roman Yeryomin
On 30 December 2015 at 14:32, Yousong Zhou wrote: > On 30 December 2015 at 20:12, Jo-Philipp Wich wrote: >> Hi Yousong. >> >> NAK - thats by design. If a network config is present then there is no >> point in regenerating it. >> >> I'd prefer if the Malta target would simply drop its default conf

Re: [OpenWrt-Devel] [PATCH] base-files: fix generating network configuration

2015-12-30 Thread Yousong Zhou
On Wednesday, 30 December 2015, Nathan Hintz wrote: > Hi: > On Dec 30, 2015 4:01 AM, Yousong Zhou > wrote: > > > > With the default /e/c/network present, board_detect won't create a new > > config from board.json. Move this default configuration to > > generate_static_network of config_generate

Re: [OpenWrt-Devel] [PATCH] base-files: fix generating network configuration

2015-12-30 Thread Nathan Hintz
Hi: On Dec 30, 2015 4:01 AM, Yousong Zhou wrote: > > With the default /e/c/network present, board_detect won't create a new > config from board.json.  Move this default configuration to > generate_static_network of config_generate instead. > > This should fix the issue on malta target and should n

Re: [OpenWrt-Devel] [PATCH] base-files: fix generating network configuration

2015-12-30 Thread Yousong Zhou
On 30 December 2015 at 20:12, Jo-Philipp Wich wrote: > Hi Yousong. > > NAK - thats by design. If a network config is present then there is no > point in regenerating it. > > I'd prefer if the Malta target would simply drop its default config and > switch to board.d, this could be useful to e.g. dy

Re: [OpenWrt-Devel] [PATCH] base-files: fix generating network configuration

2015-12-30 Thread Jo-Philipp Wich
Hi Yousong. NAK - thats by design. If a network config is present then there is no point in regenerating it. I'd prefer if the Malta target would simply drop its default config and switch to board.d, this could be useful to e.g. dynamically handle different amounts of eth* devices: eth0 -> lan

[OpenWrt-Devel] [PATCH] base-files: fix generating network configuration

2015-12-30 Thread Yousong Zhou
With the default /e/c/network present, board_detect won't create a new config from board.json. Move this default configuration to generate_static_network of config_generate instead. This should fix the issue on malta target and should not affect other targets that provide its own default network