Re: [OpenWrt-Devel] [PATCH] base-files: execute package prerm script in a subshell

2018-08-25 Thread Luis Araneda
Hi, On Thu, Aug 23, 2018 at 10:30 PM Philip Prindeville wrote: > [...] > > On Aug 23, 2018, at 6:21 PM, Luis Araneda wrote: > > [...] Someone point me to a Github pull-request [1] that already fixes this problem, with some small differences. Especially, it continues to execute the function if t

Re: [OpenWrt-Devel] [PATCH] base-files: execute package prerm script in a subshell

2018-08-23 Thread Philip Prindeville
LGTM > On Aug 23, 2018, at 6:21 PM, Luis Araneda wrote: > > This fixes a problem that's causing an early return of > default_prerm() when the package prerm script has an > exit statement at the end, which is implemented as > "exit 0" by most of the packages that use prerm > > With the new beha

[OpenWrt-Devel] [PATCH] base-files: execute package prerm script in a subshell

2018-08-23 Thread Luis Araneda
This fixes a problem that's causing an early return of default_prerm() when the package prerm script has an exit statement at the end, which is implemented as "exit 0" by most of the packages that use prerm With the new behavior, the execution of default_prerm() will continue only if the prerm scr