Re: [OpenWrt-Devel] [PATCH] add support for WRTnode2P and WRTnode2R add led support for wrtnode platform

2015-12-24 Thread John Crispin
On 24/12/2015 10:16, Piotr Dymacz wrote: > Hello, > > Small comment inline, below. > > Plus: > 1. This patch is not for trunk, so you should add "CC" prefix in the subject. small addition. for us to merge board support into CC it needs to first be merged into trunk. i cannot accept a patch for

Re: [OpenWrt-Devel] [PATCH] add support for WRTnode2P and WRTnode2R add led support for wrtnode platform

2015-12-24 Thread Piotr Dymacz
Hello, Small comment inline, below. Plus: 1. This patch is not for trunk, so you should add "CC" prefix in the subject. 2. Both models are very similar, my suggestion is to use common dtsi (ex. Lenovo Y1). Cheers, Piotr 2015-12-24 9:56 GMT+01:00 xzmu : > Signed-off-by: xzmu > --- > .../linux/

[OpenWrt-Devel] [PATCH] add support for WRTnode2P and WRTnode2R add led support for wrtnode platform

2015-12-24 Thread xzmu
Signed-off-by: xzmu --- .../linux/ramips/base-files/etc/board.d/02_network | 2 + target/linux/ramips/base-files/etc/diag.sh | 5 + target/linux/ramips/base-files/lib/ramips.sh | 6 ++ .../ramips/base-files/lib/upgrade/platform.sh | 2 + target/linux/ramips/dts/WRTNODE2

Re: [OpenWrt-Devel] [PATCH] add support for WRTnode2P and WRTnode2R

2015-12-24 Thread John Crispin
Hi, the patch is badly formatted. please read the SubmittingPatches howto. things to look out for are * subject prefix * description that reflects hte actual patch content * your signed-off line is at the end of the patch. please put it above the tear line instead. you should consider using "git

[OpenWrt-Devel] [PATCH] add support for WRTnode2P and WRTnode2R

2015-12-23 Thread xzmu
Hi blogic this is a patch is add WRTnode2P and WRTnode2R support by OpenWrt commit d0f7a56ed622a488926bb1705686b950dea34cce Author: xzmu Date: Thu Dec 24 15:30:07 2015 +0800 add support for WRTnode2P and WRTnode2R add led indicator support for WRTnode platform diff --git a/target/lin