Re: [OpenWrt-Devel] [PATCH] Keep /etc/nginx on sysupgrade

2012-08-24 Thread Mark Mentovai
Jo-Philipp Wich wrote: > But they will get recorded by opkg, which is another source sysupgrade > uses to assemble the list of files to get backed up. This is the part I was missing. Thanks for the explanation. I've submitted a v2 patch in case it's thought to be generally useful, otherwise I'll

Re: [OpenWrt-Devel] [PATCH] Keep /etc/nginx on sysupgrade

2012-08-24 Thread Jo-Philipp Wich
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > I see. The existing feeds/packages/net/nginx/Makefile already lists > the files under /etc/nginx that ship in the package in its > conffiles definition, but this doesn't result in a keep file in the > package because include/package-ipkg.mk will onl

Re: [OpenWrt-Devel] [PATCH] Keep /etc/nginx on sysupgrade

2012-08-24 Thread Mark Mentovai
Jo-Philipp Wich wrote: > > It looks like conffiles can only save files, not entire directories. > > /etc/nginx is a directory. Should conffiles be fixed to work with > > directories too? > > It works fine with directories, see include/package-ipkg.mk, the code > below "ifneq ($$(KEEP_$(1)),)" I s

Re: [OpenWrt-Devel] [PATCH] Keep /etc/nginx on sysupgrade

2012-08-22 Thread Jo-Philipp Wich
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > It looks like conffiles can only save files, not entire directories. > /etc/nginx is a directory. Should conffiles be fixed to work with > directories too? It works fine with directories, see include/package-ipkg.mk, the code below "ifneq ($$(KEEP_$

Re: [OpenWrt-Devel] [PATCH] Keep /etc/nginx on sysupgrade

2012-08-22 Thread Mark Mentovai
Jo-Philipp Wich wrote: > Hi. > > You do not need to ship a keep file, it is enough to add /etc/nginx to > the conffiles define. It looks like conffiles can only save files, not entire directories. /etc/nginx is a directory. Should conffiles be fixed to work with directories too? _

Re: [OpenWrt-Devel] [PATCH] Keep /etc/nginx on sysupgrade

2012-08-22 Thread Jo-Philipp Wich
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi. You do not need to ship a keep file, it is enough to add /etc/nginx to the conffiles define. ~ Jow -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAlA0u

[OpenWrt-Devel] [PATCH] Keep /etc/nginx on sysupgrade

2012-08-21 Thread Mark Mentovai
Signed-off-by: Mark Mentovai --- Index: packages/net/nginx/Makefile === --- packages/net/nginx/Makefile (revision 33213) +++ packages/net/nginx/Makefile (working copy) @@ -103,6 +103,8 @@ $(INSTALL_DATA) $(addprefix $(PKG_I