Re: [OpenWrt-Devel] [PATCH] Fix leds-gpio brightness for active_low LEDs

2008-01-16 Thread Peter Korsgaard
> "Imre" == Imre Kaloz <[EMAIL PROTECTED]> writes: Hi, Imre> About the code history - The only code from Aruba Networks is Imre> the ethernet driver, but even that went through heavy Imre> modifications. The system code is based on Atheros' 2.4.25 Imre> port, which got published in variou

Re: [OpenWrt-Devel] [PATCH] Fix leds-gpio brightness for active_low LEDs

2008-01-15 Thread Imre Kaloz
2008.01.15. 21:34:25 dátumon Peter Korsgaard <[EMAIL PROTECTED]> írta: >> "Felix" == Felix Fietkau <[EMAIL PROTECTED]> writes: > > Hi, > > >> Talking of which, I recently dug out my lafonera and put openwrt on > >> it. Is anyone working on getting the kernel code submitted upstream? > >> O

Re: [OpenWrt-Devel] [PATCH] Fix leds-gpio brightness for active_low LEDs

2008-01-15 Thread Felix Fietkau
Peter Korsgaard wrote: >> "Felix" == Felix Fietkau <[EMAIL PROTECTED]> writes: > > Hi, > > >> Talking of which, I recently dug out my lafonera and put openwrt on > >> it. Is anyone working on getting the kernel code submitted upstream? > >> Otherwise I'll start by cleaning up the ethernet

Re: [OpenWrt-Devel] [PATCH] Fix leds-gpio brightness for active_low LEDs

2008-01-15 Thread Peter Korsgaard
> "Felix" == Felix Fietkau <[EMAIL PROTECTED]> writes: Hi, >> Talking of which, I recently dug out my lafonera and put openwrt on >> it. Is anyone working on getting the kernel code submitted upstream? >> Otherwise I'll start by cleaning up the ethernet driver. Felix> Sounds good. I was

Re: [OpenWrt-Devel] [PATCH] Fix leds-gpio brightness for .active_low LEDs

2008-01-14 Thread Felix Fietkau
Peter Korsgaard wrote: >> "Rod" == Rod Whitby <[EMAIL PROTECTED]> writes: > > Hi, > > Rod> You're effectively creating a permanently incompatible fork of the > Rod> leds-gpio driver with your patch, whereas I thought a goal of OpenWrt > Rod> was to push kernel patches upstream wherever pos

Re: [OpenWrt-Devel] [PATCH] Fix leds-gpio brightness for .active_low LEDs

2008-01-14 Thread Peter Korsgaard
> "Rod" == Rod Whitby <[EMAIL PROTECTED]> writes: Hi, Rod> You're effectively creating a permanently incompatible fork of the Rod> leds-gpio driver with your patch, whereas I thought a goal of OpenWrt Rod> was to push kernel patches upstream wherever possible rather than Rod> carrying inc

Re: [OpenWrt-Devel] [PATCH] Fix leds-gpio brightness for .active_low LEDs

2008-01-11 Thread Nick Forbes
Rod Whitby Sent: 10 January 2008 23:36 To: OpenWrt Development List Subject: Re: [OpenWrt-Devel] [PATCH] Fix leds-gpio brightness for .active_low LEDs Nick Forbes wrote: > The leds-gpio driver initialises all LEDs in the OFF state, however it > incorrectly sets the "brightness&qu

Re: [OpenWrt-Devel] [PATCH] Fix leds-gpio brightness for .active_low LEDs

2008-01-10 Thread Rod Whitby
Nick Forbes wrote: > The leds-gpio driver initialises all LEDs in the OFF state, however > it incorrectly sets the "brightness" value to 255 (LED_FULL) for LEDs > which are ".active_low". This results in the LED being off at > initialisation, but the /sys/class/leds//brightness value being > 25

[OpenWrt-Devel] [PATCH] Fix leds-gpio brightness for .active_low LEDs

2008-01-10 Thread Nick Forbes
The leds-gpio driver initialises all LEDs in the OFF state, however it incorrectly sets the "brightness" value to 255 (LED_FULL) for LEDs which are ".active_low". This results in the LED being off at initialisation, but the /sys/class/leds//brightness value being 255 instead of 0. The attac