Ok, ACK from me then.
Thanks for taking care of the merge.
~ Jow
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
[...]
>>> + if (!S_ISREG(s.st_mode))
>>> + return UBUS_STATUS_NOT_SUPPORTED;
>>
>> should this not be -> UBUS_STATUS_INVALID_ARGUMENT
>
> I think "not supported" in response to "md5sum of a non-regular file"
> (like a chardev or directory) makes sense here - imho.
>
your codebase,
Hi,
> comments inline
dito.
> On 12/04/2015 03:56, Luka Perkov wrote:
>> Signed-off-by: Luka Perkov
>> ---
>> changes in v2:
>>
>> * no need to null-terminate string after sprintf()
>>
>> file.c | 35 +++
>> 1 file changed, 35 insertions(+)
>>
>> diff --git a/fi
hi,
comments inline
On 12/04/2015 03:56, Luka Perkov wrote:
> Signed-off-by: Luka Perkov
> ---
> changes in v2:
>
> * no need to null-terminate string after sprintf()
>
> file.c | 35 +++
> 1 file changed, 35 insertions(+)
>
> diff --git a/file.c b/file.c
>
Signed-off-by: Luka Perkov
---
changes in v2:
* no need to null-terminate string after sprintf()
file.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/file.c b/file.c
index 3831c54..9c1b301 100644
--- a/file.c
+++ b/file.c
@@ -27,6 +27,7 @@
#include
