Re: [OpenWrt-Devel] [PATCH] [ramips] Correct uartmux gpio bug

2013-05-04 Thread Michel Stempin
Le 04/05/2013 15:30, Сергей Василюгин a écrit : > > > 04.05.2013, 18:39, "John Crispin" : >> Hi >> >> i just pushed a fix that addresses this problem properly ... (i hope) >> > > > + of_property_read_string(np, "ralink,uartmux", &uart); > + if (uart) { > + mode |= rt

Re: [OpenWrt-Devel] [PATCH] [ramips] Correct uartmux gpio bug

2013-05-04 Thread Сергей Василюгин
04.05.2013, 18:39, "John Crispin" : > Hi > > i just pushed a fix that addresses this problem properly ... (i hope) > + of_property_read_string(np, "ralink,uartmux", &uart); + if (uart) { + mode |= rt_gpio_pinmux.uart_mask << rt_gpio_pinmux.uart_shift; + i

Re: [OpenWrt-Devel] [PATCH] [ramips] Correct uartmux gpio bug

2013-05-04 Thread Michel Stempin
Hi John, Thanks, I will try that. -Michel Le 04/05/2013 13:34, John Crispin a écrit : > > Hi > > i just pushed a fix that addresses this problem properly ... (i hope) > > John > ___ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > h

Re: [OpenWrt-Devel] [PATCH] [ramips] Correct uartmux gpio bug

2013-05-04 Thread John Crispin
Hi i just pushed a fix that addresses this problem properly ... (i hope) John ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] [ramips] Correct uartmux gpio bug

2013-05-03 Thread Michel Stempin
Le 03/05/2013 13:26, John Crispin a écrit : > On 03/05/13 13:14, Сергей Василюгин wrote: >> >> >> 03.05.2013, 15:40, "Michel Stempin": >>> The mask m is only null when there is no "ralink,uartmux" property defined >>> in DTS. >>> >>> When the "ralink,uartmux" property is set to "gpio", m will be

Re: [OpenWrt-Devel] [PATCH] [ramips] Correct uartmux gpio bug

2013-05-03 Thread John Crispin
On 03/05/13 13:14, Сергей Василюгин wrote: 03.05.2013, 15:40, "Michel Stempin": The mask m is only null when there is no "ralink,uartmux" property defined in DTS. When the "ralink,uartmux" property is set to "gpio", m will be equal to RT305X_GPIO_MODE_GPIO, i.e. all bits sets in the uart_ma

Re: [OpenWrt-Devel] [PATCH] [ramips] Correct uartmux gpio bug

2013-05-03 Thread Сергей Василюгин
03.05.2013, 15:40, "Michel Stempin" : > The mask m is only null when there is no "ralink,uartmux" property defined in > DTS. > > When the "ralink,uartmux" property is set to "gpio", m will be equal to > RT305X_GPIO_MODE_GPIO, i.e. all bits sets in the uart_mask, thus the proper > way to do it

Re: [OpenWrt-Devel] [PATCH] [ramips] Correct uartmux gpio bug

2013-05-03 Thread John Crispin
On 03/05/13 10:40, Michel Stempin wrote: The mask m is only null when there is no "ralink,uartmux" property defined in DTS. When the "ralink,uartmux" property is set to "gpio", m will be equal to RT305X_GPIO_MODE_GPIO, i.e. all bits sets in the uart_mask, thus the proper way to do it is to co

[OpenWrt-Devel] [PATCH] [ramips] Correct uartmux gpio bug

2013-05-03 Thread Michel Stempin
The mask m is only null when there is no "ralink,uartmux" property defined in DTS. When the "ralink,uartmux" property is set to "gpio", m will be equal to RT305X_GPIO_MODE_GPIO, i.e. all bits sets in the uart_mask, thus the proper way to do it is to compare m against the uart_mask for equality.