Re: [OpenWrt-Devel] [PATCH][libubox] ustream-fd: handle uloop errors

2015-07-12 Thread Philip Craig
On 10/07/15 21:26, Felix Fietkau wrote: > On 2015-07-10 09:23, Philip Craig wrote: >> Otherwise uloop will delete the fd and the ustream will receive no >> notification of the error. >> >> Signed-off-by: Philip Craig > I think this fix is incomplete. When an error occurs, ustream-fd should > delet

Re: [OpenWrt-Devel] [PATCH][libubox] ustream-fd: handle uloop errors

2015-07-10 Thread Felix Fietkau
On 2015-07-10 09:23, Philip Craig wrote: > Otherwise uloop will delete the fd and the ustream will receive no > notification of the error. > > Signed-off-by: Philip Craig I think this fix is incomplete. When an error occurs, ustream-fd should delete the fd after setting the error flags to avoid g

[OpenWrt-Devel] [PATCH][libubox] ustream-fd: handle uloop errors

2015-07-10 Thread Philip Craig
Otherwise uloop will delete the fd and the ustream will receive no notification of the error. Signed-off-by: Philip Craig --- ustream-fd.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/ustream-fd.c b/ustream-fd.c index 5ffca53..2c15b42 100644 --- a/ustream-fd.c +++ b