Re: [OpenWrt-Devel] [OpenWrt-Commits] r25417 - trunk/package/busybox/files

2011-02-09 Thread Vasilis Tsiligiannis
> This is at least an explicit declaration that something else ought to > be treated as ${HOME}; if someone sets it badly, all sorts of things > are subject to failure. All sorts of things can be subject to failure. Remote access cannot. -- Vasilis Tsiligiannis signature.asc Description: This

Re: [OpenWrt-Devel] [OpenWrt-Commits] r25417 - trunk/package/busybox/files

2011-02-08 Thread Philip Prindeville
On 2/8/11 3:29 AM, Vasilis Tsiligiannis wrote: On Tuesday 08 February 2011 03:51:21 Mark Mentovai wrote: I wonder why this didn’t just use ~root. There’s no way to disable tilde expansion in Busybox ash, so ~root should always be available. It would certainly be more elegant and reliable than th

Re: [OpenWrt-Devel] [OpenWrt-Commits] r25417 - trunk/package/busybox/files

2011-02-08 Thread Mark Mentovai
Vasilis Tsiligiannis wrote: > It's not so safe, as user home dir can be overriden in a shell by setting > the "$HOME" environment variable. This is at least an explicit declaration that something else ought to be treated as ${HOME}; if someone sets it badly, all sorts of things are subject to fail

Re: [OpenWrt-Devel] [OpenWrt-Commits] r25417 - trunk/package/busybox/files

2011-02-08 Thread Vasilis Tsiligiannis
On Tuesday 08 February 2011 03:51:21 Mark Mentovai wrote: > I wonder why this didn’t just use ~root. There’s no way to disable > tilde expansion in Busybox ash, so ~root should always be available. > It would certainly be more elegant and reliable than this shell > function, unless there’s a fear t

Re: [OpenWrt-Devel] [OpenWrt-Commits] r25417 - trunk/package/busybox/files

2011-02-08 Thread Vasilis Tsiligiannis
On Tuesday 08 February 2011 03:19:22 Philip Prindeville wrote: > Has this been tested where root isn't the first entry in /etc/passwd? > > Because there's no requirement for the entries to be sorted on uid... It should work regardless where "root" is placed in the file. -- Vasilis Tsiligiannis

Re: [OpenWrt-Devel] [OpenWrt-Commits] r25417 - trunk/package/busybox/files

2011-02-07 Thread Mark Mentovai
I wonder why this didn’t just use ~root. There’s no way to disable tilde expansion in Busybox ash, so ~root should always be available. It would certainly be more elegant and reliable than this shell function, unless there’s a fear that the root user might not be named root. Given that there’s prob

Re: [OpenWrt-Devel] [OpenWrt-Commits] r25417 - trunk/package/busybox/files

2011-02-07 Thread Philip Prindeville
Has this been tested where root isn't the first entry in /etc/passwd? Because there's no requirement for the entries to be sorted on uid... On 2/7/11 5:01 PM, openwrt-comm...@openwrt.org wrote: Author: acinonyx Date: 2011-02-08 02:01:17 +0100 (Tue, 08 Feb 2011) New Revision: 25417 Modified: