[OpenWrt-Devel] [PATCH v2] [ubox] kmodloader: increase module name length

2019-02-21 Thread Sergiy Kibrik via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- From: Sergiy Kibrik

Re: [OpenWrt-Devel] [PATCH] [ubox] kmodloader: increase module name length

2019-02-18 Thread Sergiy Kibrik
hi Bjørn, On 2/18/19 4:24 PM, Bjørn Mork wrote: > Agreed that 33 is not enough, but NAME_MAX is way overkill again. Why > not use the actual max length from the kernel?: > > include/linux/module.h:#define MODULE_NAME_LEN MAX_PARAM_PREFIX_LEN > include/linux/moduleparam.h:#define MAX_PARAM_PREF

[OpenWrt-Devel] [PATCH] [ubox] kmodloader: increase module name length

2019-02-18 Thread Sergiy Kibrik
Otherwise modules with long names, e.g. lttng (>32 chars) can't be loaded. Signed-off-by: Sergiy Kibrik --- kmodloader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kmodloader.c b/kmodloader.c index 3196deb..67e3706 100644 --- a/kmodloader.c +++ b/kmodloader.c @

Re: [OpenWrt-Devel] [PATCH procd] cmake: use CMAKE_INSTALL_* variables

2015-10-13 Thread Sergiy Kibrik
On 10/12/15 4:50 PM, Felix Fietkau wrote: > On 2015-09-17 13:54, Sergiy Kibrik wrote: >> Replace hard-coded installation directories with cmake-provided >> variables, which gives more flexibility on where to install >> final binaries. Great simplification for usage with

[OpenWrt-Devel] [PATCH v2 procd] cmake: use CMAKE_INSTALL_* variables

2015-10-13 Thread Sergiy Kibrik
Replace hard-coded installation directories with cmake-provided variables, which gives more flexibility on where to install final binaries. Great simplification for usage with e.g. BitBake recipes. Signed-off-by: Sergiy Kibrik --- CMakeLists.txt | 19 ++- 1 file changed, 10

[OpenWrt-Devel] [PATCH procd] cmake: use CMAKE_INSTALL_* variables

2015-09-17 Thread Sergiy Kibrik
Replace hard-coded installation directories with cmake-provided variables, which gives more flexibility on where to install final binaries. Great simplification for usage with e.g. BitBake recipes. Signed-off-by: Sergiy Kibrik --- CMakeLists.txt | 18 +- 1 file changed, 9

[OpenWrt-Devel] [PATCH] [procd] inittab: always proceed to next state

2015-08-19 Thread Sergiy Kibrik
If no S or K rc scripts provided we still should be able to go on to next state, or we won't boot properly and would not be able to reboot/shutdown later. Signed-off-by: Sergiy Kibrik --- inittab.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/inittab.c b/init

[OpenWrt-Devel] [PATCH v2] [libubox] ulog: avoid accidental /dev/kmsg creation

2015-08-17 Thread Sergiy Kibrik
oid this we open file in "r+" mode which doesn't create file if it's not found. Signed-off-by: Sergiy Kibrik Cc: John Crispin --- ulog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ulog.c b/ulog.c index 776a0c4..80b67ac 100644 --- a/ulog.c +++ b/ulog.c @

Re: [OpenWrt-Devel] [PATCH] [libubox] ulog: check if /dev/kmsg is special file

2015-08-17 Thread Sergiy Kibrik
hi John, > the patch is quite invasive. how about just using "r+" > > from the man page --> "r+ Open for reading and writing. The stream > is positioned at the beginning of the file." > > could you try the following and not apply any other changes ? > > John > > - if ((kmsg = fopen

[OpenWrt-Devel] [PATCH] [libubox] ulog: check if /dev/kmsg is special file

2015-08-16 Thread Sergiy Kibrik
this we check if file we're going to write to is really character special and ensure it doesn't go away while we check. Signed-off-by: Sergiy Kibrik --- ulog.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/ulog.c b/ulog.c index 776a0c4..10d61da 1