Re: [OpenWrt-Devel] [PATCH] enhance rtl8366rb driver v2

2010-09-29 Thread Luca Niccoli
On 30 September 2010 01:12, Roman Yeryomin wrote: >> +       if (val->port_vlan < 5) { > > RTL8366RB_PORT_NUM_CPU? Sure > if to follow your logic you should append `|| val->value.i < 0` also Actually, this way one can use both 0 or any negative value to set unlimited bandwidth. I would find nat

Re: [OpenWrt-Devel] [PATCH] enhance rtl8366rb driver v2

2010-09-29 Thread Luca Niccoli
On 29 September 2010 22:23, Luca Niccoli wrote: > (I still have to test the effect it has, though.) I'll have to rework this a bit, the switch can base its priority decisions on port, 802.1q priority tag, DSCP IP tag and ACL, so that needs to be set as well. Cheer

Re: [OpenWrt-Devel] [PATCH] enhance rtl8366rb driver v2

2010-09-29 Thread Luca Niccoli
On 29 September 2010 11:27, Roman Yeryomin wrote: > Realtek storm filtering code is commented out in rtl8366rb_api.c and > there are different registers defined in rtl8366rb_api.h - that's why > I'm in doubt. I know, but I thought the feature was cool enough to give it a try and it worked. > Ho

Re: [OpenWrt-Devel] [PATCH] enhance rtl8366rb driver v2

2010-09-29 Thread Luca Niccoli
On 28 September 2010 21:19, Roman Yeryomin wrote: > I mean that storm filtering registers are different and seems that the > logic should be too, but the original driver is confusing also that's > why I ask if you've tested this. I did test storm filtering; it definitely works with broadcast and

[OpenWrt-Devel] [PATCH] enhance rtl8366rb driver v2

2010-09-28 Thread Luca Niccoli
This second version of the patch is rebased on the work done by Roman Yeryomin and applied in r23126. It corrects a minor miscalculation in the port rate code and cleans the code a bit, plus it adds support for jumbo frames, port priority and storm control. Signed-off-by: Luca Niccoli Index

[OpenWrt-Devel] [PATCH] enhance rtl8366rb driver

2010-09-27 Thread Luca Niccoli
: Luca Niccoli Index: target/linux/generic/files/drivers/net/phy/rtl8366rb.c === --- target/linux/generic/files/drivers/net/phy/rtl8366rb.c (revisione 23125) +++ target/linux/generic/files/drivers/net/phy/rtl8366rb.c (copia