Re: [PATCH] base-files: fix nand_upgrade_ubinized()

2023-04-10 Thread Lanchon
On 4/10/23 15:38, Daniel Golle wrote: On Mon, Apr 10, 2023 at 07:01:35PM +0200, Rafał Miłecki wrote: From: Rafał Miłecki When using "ubiformat" with stdin it requires passing image size using the -S argument. Provide it just like we do for "ubiupdatevol". This fixes: ubiformat: error!: must

Re: sysupgrade broken on imx nand targets (and maybe others too)

2023-01-24 Thread Lanchon
On 1/24/23 18:08, Koen Vandeputte wrote: Hi, I think our previous mails overlapped a bit as I didn't notice your previous response :) I'll send the data tomorrow. I'm also wondering if adding a sleep before ubiformat in the old way would influence/break it's behaviour? possibly yes Pio

Re: sysupgrade broken on imx nand targets (and maybe others too)

2023-01-24 Thread Lanchon
On 1/24/23 17:35, Lanchon wrote: On 1/24/23 13:25, Koen Vandeputte wrote: On Tue, Jan 24, 2023 at 4:26 PM Koen Vandeputte wrote: On Tue, Jan 24, 2023 at 7:59 AM Lanchon wrote: hi Koen, thanks again. i copied your log here for ease of reference: https://gist.github.com/Lanchon

Re: sysupgrade broken on imx nand targets (and maybe others too)

2023-01-24 Thread Lanchon
On 1/24/23 13:25, Koen Vandeputte wrote: On Tue, Jan 24, 2023 at 4:26 PM Koen Vandeputte wrote: On Tue, Jan 24, 2023 at 7:59 AM Lanchon wrote: hi Koen, thanks again. i copied your log here for ease of reference: https://gist.github.com/Lanchon/f24ea9c16eda5ffaa5085a7b240238db first let

Re: sysupgrade broken on imx nand targets (and maybe others too)

2023-01-24 Thread Lanchon
On 1/24/23 12:26, Koen Vandeputte wrote: On Tue, Jan 24, 2023 at 7:59 AM Lanchon wrote: hi Koen, thanks again. i copied your log here for ease of reference: https://gist.github.com/Lanchon/f24ea9c16eda5ffaa5085a7b240238db first let me say: - ubinized sysupgrade is not used by any of my

Re: sysupgrade broken on imx nand targets (and maybe others too)

2023-01-23 Thread Lanchon
hi Koen, thanks again. i copied your log here for ease of reference: https://gist.github.com/Lanchon/f24ea9c16eda5ffaa5085a7b240238db first let me say: - ubinized sysupgrade is not used by any of my devices. - ubinized sysupgrade happens when when an ubi partition image is fed as an upgrade

Re: sysupgrade broken on imx nand targets (and maybe others too)

2023-01-23 Thread Lanchon
hi Koen, thanks for this detailed report, i'll try to take a look at it tonight. thank you again. On 1/23/23 12:37, Koen Vandeputte wrote: Hi Rodrigo, After a long absence and now testing the latest master, I noticed that imx nand flash sysupgrade was broken: expected behaviour: - scan the

Re: [PATCH] base-files: fix sysupgrade with ubi and kernel sharing partition

2022-05-04 Thread Lanchon
On 5/4/22 12:09, Sungbo Eo wrote: On 2022-05-02 17:10, Bjørn Mork wrote: I can understand that. I have not been able to find any other examples, so I have to take full responsibility for this unexpected configuration. I guess I thought it would make sense to have a "Kernel" partition large enou

Re: [PATCH] base-files: fix sysupgrade with ubi and kernel sharing partition

2022-05-02 Thread Lanchon
hi, sorry for the delay. I didn't expect that kind of sharing. your fix is not enough: when later the partition is written, it is via 'mtd -n write' which expects an erased partition. i will do a PR ASAP to fix this by invalidating the start of the kernel partition instead of erasing it, thi