Re: Missing 'libubus.so' and change of ABI in 19.07.8

2021-11-13 Thread Giovanni Giacobbi
On 13/11/2021 18:47, Jo-Philipp Wich wrote: But I really can't see the breaking change, could you please point it out for me? struct ubus_client changed its layout. Ok but isn't that affecting only the binary executable 'ubusd'? I don't see 'libubus.so' including 'ubusd.h' even indirectly.

Missing 'libubus.so' and change of ABI in 19.07.8

2021-11-13 Thread Giovanni Giacobbi
Greetings. I have two questions about a recent change related to ubus package in 19.07.8. The first question is related to the ABI version change from 20191227 to 20210603. The changeset in the ubus repository the following: git diff 041c9d1..38c7fdd CMakeLists.txt | 4 lua/ubus.c

[PATCH ubox] logread: fix erroneous message "Logread connected to" when using udp

2021-07-27 Thread Giovanni Giacobbi
, only one initial message "Logread streaming to..." is logged. Also fixed capital letter for "failed to send" message. Signed-off-by: Giovanni Giacobbi --- log/logread.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/log/logread.c b/log/log

Re: [PATCH ubox] logd: fix priviledge dropping order

2021-07-27 Thread Giovanni Giacobbi
On 27/07/2021 14:39, Giovanni Giacobbi wrote: Fixes: 41664054b8b1 ("logd: fix ignored return values in set{gid,uid}") Signed-off-by: Giovanni Giacobbi --- log/logd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Let me add some remarks about this change. Commen

[PATCH ubox] logd: fix priviledge dropping order

2021-07-27 Thread Giovanni Giacobbi
Fixes: 41664054b8b1 ("logd: fix ignored return values in set{gid,uid}") Signed-off-by: Giovanni Giacobbi --- log/logd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/log/logd.c b/log/logd.c index 5d6c458..594b1e0 100644 --- a/log/logd.c +++ b/log/logd.c

Re: [PATCH 19.07 4/4] treewide: mark selected packages nonshared

2021-07-09 Thread Giovanni Giacobbi
On 04/07/2021 14:46, Adrian Schmutzler wrote: PKG_NAME:=json-c PKG_VERSION:=0.12.1 -PKG_RELEASE:=3.1 +PKG_RELEASE:=3.2 I've never seen a non integer release, is there a special reason for this? I've also used this as standard scheme for changes in stable branches. The advantage is that y

[PATCH urngd] Fix busy loop in case of ioctl(RNDADDENTROPY) failure

2021-01-30 Thread Giovanni Giacobbi
} } static void urngd_done(struct urngd *u) -- Giovanni Giacobbi ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel