,
Bruno Pena
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
n GitHub.
Best regards,
Bruno Pena
On Wed, Jan 22, 2020, 13:03 Steve Brown wrote:
> Hi Bruno,
>
> Your suggested fix works on my TPLink A7-V5.
>
> diff --git a/target/linux/ath79/image/common-tp-link.mk
> b/target/linux/ath79/image/common-tp-link.mk
> index 9048e8340c..8a
Hi Steve,
Glad to hear that and thank you for testing it!
I will probably ask you to do one additional test to see if we're able to
remove the padding requirement (as mentioned on the previous emails).
But let me test it first so I can confirm that it actually works.
Best regards,
Bruno
Hi Steve,
Don't waste your time with the previous test request.
I'll try to test either today/tomorrow the "mtd.orig_flags" approach on my
device and - if successful - I'll then ask if you can try it on your
TP-Link.
Thank you and best regards,
Bruno Pena
On Wed, Jan 2
Just a small correction on the previous email, there's actually no padding
requirement since everything will be read-only!
On Wed, Jan 22, 2020, 11:25 Bruno Pena wrote:
> Hi Daniel,
>
> I was looking at the code and I think it's possible to relax the
> enforcement of
mind is that the padding is still a requirement for
those devices which are building a read-only firmware partition!
Also please note this is not tested, these conclusions are only based on
the analysis of the kernel source code.
Best regards,
Bruno Pena
On Wed, Jan 22, 2020, 10:40 Daniel Golle
o like to take the opportunity to ask if it's worth pursuing
this patch if it means that all devices (using mtd) will require their
partitions to be padded to the blocksize?
Thank you and best regards,
Bruno Pena
On Wed, Jan 22, 2020, 07:13 Bruno Pena wrote:
> Hi Steve,
>
>
to 64k (32k on average) just to round the
partition to the blocksize.
However, due to how mtd is implemented the padding is actually a
requirement for this kernel patch to work properly.
Best regards,
Bruno Pena
On Tue, Jan 21, 2020 at 11:51 PM Mathias Kresin wrote:
> 21/01/2020 22:10, Br
nk.mk before I waste more of your time with these tests.
Best regards,
Bruno Pena
On Wed, Jan 22, 2020 at 12:16 AM Steve Brown wrote:
> Hi Bruno,
>
> That didn't seem to solve the problem. The padding didn't seem to take
> effect.
>
> I reverted 0f81a0979 and 0c707d
to the blocksize (untested suggestion
below):
define Device/tplink-safeloader
$(Device/tplink)
KERNEL := kernel-bin | append-dtb | lzma | pad-to (BLOCKSIZE) |
tplink-v1-header -O
[...]
Would any of you be willing to spend some time testing this change on your
TP-Link?
Thank you and bes
nly
extends the "mtd_add_partition" function but it does not add any code to
force the access mode on sub-partitions).
The reason for this is because this enforcement is done on the mtd parser
code that is OpenWrt specific and implemented via kernel patches (not
present on upstream).
Best regards,
B
e for this device I see that "firmware" is
read-write, so I wonder if there's something else marking these as
read-only.
Best regards,
Bruno Pena
On Tue, Jan 21, 2020, 11:55 Daniel Golle wrote:
> Hi Bruno,
> Hi Steve,
>
> On Tue, Jan 21, 2020 at 11:24:28AM +0100, Bruno Pe
Thank you for the details.
Did you had only to revert de80424f7 (kernel patch) or did you also had to
revert the fstools patch?
Best regards,
Bruno Pena
On Tue, Jan 21, 2020, 12:09 Steve Brown wrote:
> Below:
>
> Steve
>
>
>
> /pr
Please also include the contents of "dmesg" and of the files
"/proc/cmdline" and "/proc/mtd".
Best regards,
Bruno Pena
On Tue, Jan 21, 2020, 11:01 Bruno Pena wrote:
> Hi Steve,
>
> These patches should only impact partitions that are marked as read only
Hi Steve,
These patches should only impact partitions that are marked as read only.
Can you please provide more details about your configuration?
(architecture, device profile, mtd layout, the mtd partition generating the
error)
Best regards,
Bruno Pena
On Tue, Jan 21, 2020, 10:51 Steve Brown
with the main firmware (eg. user gets locked out
due to bad settings, flash of an unbootable dev firmware, etc).
Signed-off-by: Bruno Pena
---
libfstools/mtd.c | 19 +++
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/libfstools/mtd.c b/libfstools/mtd.c
index 77c71ee
16 matches
Mail list logo
