Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH] busybox: sysntpd - Support for NTP servers received via DHCP(v6)

2016-05-20 Thread Amine Aouled Hamed
Hi, Please add raw triggers to only the interfaces specified in the list. Regards, Amine. On Fri, May 20, 2016 at 4:11 PM, Hans Dedecker wrote: > On Fri, May 20, 2016 at 3:59 PM, Conor O'Gorman wrote: >> >> >> On 20/05/16 14:43, Hans Dedecker wrote: >>> >>> On Fri, May 20, 2016 at 3:18 PM, Davi

Re: [OpenWrt-Devel] [PATCH] busybox: sysntpd - Support for NTP servers received via DHCP(v6)

2016-05-20 Thread Amine Aouled Hamed
Hi, Please add raw triggers to only the interfaces specified in the list. Regards, Amine. On Thu, May 19, 2016 at 6:57 PM, Hans Dedecker wrote: > The busybox ntpd utility currently uses ntp servers specified in uci. > This patch allows the ntpd utility to use NTP servers received via DHCP(v6) >

Re: [OpenWrt-Devel] [PATCH] busybox: sysntpd - Support for NTP servers received via DHCP(v6)

2016-05-20 Thread Amine Aouled Hamed
Hi, One feature that was requested is the ability to specify a list of interfaces to get servers from. You can save the list as an option to the config file and add a trigger to only those interfaces. Regards, Amine. On Thu, May 19, 2016 at 6:57 PM, Hans Dedecker wrote: > The busybox ntpd utilit

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH] busybox: sysntpd - Support for NTP servers received via DHCP(v6)

2016-05-20 Thread Amine Aouled Hamed
Hi, One feature that was requested is the ability to specify a list of interfaces to get servers from. You can save the list as an option to the config file and add a trigger to only those interfaces. Regards, Amine. On Fri, May 20, 2016 at 11:01 AM, Jo-Philipp Wich wrote: > Hi Hans, > > > I wan

Re: [OpenWrt-Devel] [PATCH] Add support for multiple RADIUS servers

2016-04-20 Thread Amine Aouled Hamed
My bad, will send a new patch. On Wed, Apr 20, 2016 at 8:21 PM, John Crispin wrote: > > > On 20/04/2016 20:09, Rafał Miłecki wrote: > > On 20 April 2016 at 16:48, amine.ahd wrote: > >> Hostapd allows more than one RADIUS server to be added in case the main > server goes down. > >> This allows n

Re: [OpenWrt-Devel] Procd: Weird behaviour when adding multiple triggers

2016-02-04 Thread Amine Aouled Hamed
Can anyone confirm this issue so I could try and find a fix for it? ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] memory leak in procd

2016-02-01 Thread Amine Aouled Hamed
So did the patch fix the problem and is it going to be added to the official procd repo? On Thu, Jan 28, 2016 at 5:32 PM, Felix Fietkau wrote: > On 2016-01-28 15:39, Kenneth Johansson wrote: > > when using rpcd and updating config files using the ubus interface there > > is a memory leak in pr

Re: [OpenWrt-Devel] Procd: Weird behaviour when adding multiple triggers

2016-01-29 Thread Amine Aouled Hamed
cat /etc/banner: Bleeding Edge, r48488 On Fri, Jan 29, 2016 at 11:18 AM, Amine Aouled Hamed wrote: > > Hi, > When adding an interface trigger to sysntpd, the trigger won't work when > another trigger is present(in this case a reload trigger for system). > below is the servi

[OpenWrt-Devel] Procd: Weird behaviour when adding multiple triggers

2016-01-29 Thread Amine Aouled Hamed
Hi, When adding an interface trigger to sysntpd, the trigger won't work when another trigger is present(in this case a reload trigger for system). below is the service_triggers function I used for sysntpd: service_triggers() { local script=$(readlink "$initscript") local name=$(basename ${

Re: [OpenWrt-Devel] [PATCH] busybox: sysntpd - use NTP servers received via DHCP

2016-01-26 Thread Amine Aouled Hamed
Anyone tried both triggers at the same time and checked if it works correctly? On Mon, Jan 25, 2016 at 5:05 PM, Amine Aouled Hamed wrote: > this is the patch: > --- > package/utils/busybox/files/sysntpd | 8 > 1 file changed, 8 insertions(+) > > diff --git a/pac

Re: [OpenWrt-Devel] [PATCH] busybox: sysntpd - use NTP servers received via DHCP

2016-01-25 Thread Amine Aouled Hamed
igger + procd_add_reload_trigger "system" procd_add_validation validate_ntp_section } What I found is that commenting out the system reload trigger will make the interface trigger work. Maybe a bug when adding multiple triggers? On Mon, Jan 25, 2016 at 3:14 PM, Bastian Bitto

Re: [OpenWrt-Devel] [PATCH] busybox: ntpd - Add support for NTP servers received from DHCP

2016-01-25 Thread Amine Aouled Hamed
My bad, could this be deleted please? Thanks On Mon, Jan 25, 2016 at 5:03 PM, amine ahd wrote: > --- > package/utils/busybox/files/sysntpd | 8 > 1 file changed, 8 insertions(+) > > diff --git a/package/utils/busybox/files/sysntpd > b/package/utils/busybox/files/sysntpd > index f73bb83

Re: [OpenWrt-Devel] [PATCH] busybox: sysntpd - use NTP servers received via DHCP

2016-01-25 Thread Amine Aouled Hamed
So using the latest procd version, I added a simple logger message on top start_service() in sysntpd and added the triggers in service_triggers and to test I just unplugged and re-plugget my network cable and checked logread. Nothing shows up. On Mon, Jan 25, 2016 at 10:26 AM, Amine Aouled Hamed

Re: [OpenWrt-Devel] [PATCH] busybox: sysntpd - use NTP servers received via DHCP

2016-01-25 Thread Amine Aouled Hamed
Hi Felix, Actually I made my tests on an old version of OpenWrt, maybe procd changed since that version. Will make another tests using the current version and let you know of the results. On Fri, Jan 22, 2016 at 2:39 PM, Felix Fietkau wrote: > On 2016-01-22 14:12, Amine Aouled Hamed wr

Re: [OpenWrt-Devel] [PATCH] busybox: sysntpd - use NTP servers received via DHCP

2016-01-22 Thread Amine Aouled Hamed
Hi, I tried this method the first time but it does nothing. I just tried it again now and the same thing happens (added a log message to logread in case it is restarted). Thats why I went to the hotplug script, add to it the fact that we cant choose specific interfaces to listen to using this metho

Re: [OpenWrt-Devel] [PATCH] use NTP server received via DHCP

2016-01-20 Thread Amine Aouled Hamed
Ah sorry, I thought he meant the description of the patch. Will change it now On Wed, Jan 20, 2016 at 10:14 AM, Bastian Bittorf wrote: > * amine ahd [20.01.2016 10:09]: > > thank you! > > > The current state of NTP is to load the list of NTP servers > > from the static file /etc/config/system.

Re: [OpenWrt-Devel] [PATCH 1/1] use NTP server received via DHCP

2016-01-15 Thread Amine Aouled Hamed
> > please make var 'iface' local and while you are there, move > all the 'local' declaration to the head of the function. Wouldn't be better if the local vars inside of the if and for statements stay inside? I mean what is the point of declaring ifaces if I will be using all the ifaces? in term o

Re: [OpenWrt-Devel] [PATCH 1/1] use NTP server received via DHCP

2016-01-13 Thread Amine Aouled Hamed
Apologies, I was working with an old fork of Openwrt. another version (hopefully the last) will be sent soon. Regards, Amine. On Tue, Jan 12, 2016 at 10:20 AM, Bastian Bittorf wrote: > * amine ahd [12.01.2016 10:08]: > > --- > > package/utils/busybox/Makefile | 3 ++ > > package/

Re: [OpenWrt-Devel] [PATCH 1/1] [DEV-1329] use NTP server received via DHCP

2016-01-07 Thread Amine Aouled Hamed
On Thu, Jan 7, 2016 at 2:42 PM, Bastian Bittorf wrote: > when looking at the present code, it > returns when the static list is empty. > > maybe it's a rare condition, but your code > changes the behavior. for now ignore this > and polish the rest, lets see what the others say. > > bye, bastian >

Re: [OpenWrt-Devel] [PATCH] use NTP server received via DHCP

2016-01-05 Thread Amine Aouled Hamed
Happy new year! Thanks for the explanation, I will be sending a new patch today. Regards, Amine. On Wed, Dec 30, 2015 at 2:14 PM, Yousong Zhou wrote: > Hi, > > On 30 December 2015 at 20:12, Amine Aouled Hamed > wrote: > > > > Hi, > > Can you elaborate more on

Re: [OpenWrt-Devel] [PATCH] use NTP server received via DHCP

2015-12-30 Thread Amine Aouled Hamed
Hi, Can you elaborate more on why you prefer uci state? I am just starting with OpenWRT and the first thing I found was procd. Regards, Amine. On Thu, Dec 24, 2015 at 2:35 PM, Yousong Zhou wrote: > Hi, amine > > On 23 December 2015 at 00:00, amine ahd wrote: > > The current state of NTP is to