Re: [RFC PATCH 00/14] odhcpd config value clamping

On Sun, Jun 30, 2024 at 10:32:42PM +0200, Paul D wrote: > On 2024-05-10 00:30, Paul Donald wrote: > > Clamp values read from config to RFC mandated sane values instead of just > > complaining. We also now implement valid_lifetime for ULA prefixes. > > This is useful if you need to sunset or remove

Re: [RFC PATCH 13/14] config: clamp dhcpv6_hostid_len

On Fri, May 10, 2024 at 12:30:45AM +0200, Paul Donald wrote: > From: Paul Donald > > Attempt to be helpful. > > Signed-off-by: Paul Donald > --- > src/config.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/src/config.c b/src/config.c > index f4eaa3b..4d3

Re: [RFC PATCH 12/14] config: clamp ra_mtu into 1280-65535 range

On Fri, May 10, 2024 at 12:30:44AM +0200, Paul Donald wrote: > From: Paul Donald > > (ipv6 packets can be up to 4GB in size...) > > The old logic had a logic error of || instead of && I would ask you to move the fix in a dedicated patch separate from this series (so I can merge it quicker) >

Re: [RFC PATCH 08/14] router: clamp prefix valid_lt to interface valid_lifetime

On Fri, May 10, 2024 at 12:30:40AM +0200, Paul Donald wrote: > From: Paul Donald > > Before: > == > ICMPv6 Option (Prefix information : fd26:3c30:a222::/64) > Type: Prefix information (3) > Length: 4 (32 bytes) > Prefix Length: 64 > Flag: 0xc0, On-link flag(L), Autonomous address-

Re: [RFC PATCH 11/14] config: clamp ra_retranstime

On Fri, May 10, 2024 at 12:30:43AM +0200, Paul Donald wrote: > From: Paul Donald > > Attempt to be helpful. > > Signed-off-by: Paul Donald > --- > src/config.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/src/config.c b/src/config.c > index e0f2d80..160d7d

Re: [RFC PATCH 10/14] config: clamp ra_hoplimit to maximum (instead of complaining)

On Fri, May 10, 2024 at 12:30:42AM +0200, Paul Donald wrote: > From: Paul Donald > > Attempt to be helpful. > > Signed-off-by: Paul Donald > --- > src/config.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/src/config.c b/src/config.c > index 54fb9b5..e0f

Re: [RFC PATCH 09/14] config: clamp ra_reachabletime to RFC maximum (instead of complaining)

On Fri, May 10, 2024 at 12:30:41AM +0200, Paul Donald wrote: > From: Paul Donald > > Attempt to be helpful. Better commit description please. (also apply this to every other comment, declerative comments and NOT as continuation of title) > > Signed-off-by: Paul Donald > --- > src/config.c |

Re: [RFC PATCH 02/14] router: Apply updated values from RFC8319 (updates RFC4861) to RA/ND

On Fri, May 10, 2024 at 12:30:34AM +0200, Paul Donald wrote: > From: Paul Donald > > https://www.rfc-editor.org/rfc/rfc8319#section-4 > > Signed-off-by: Paul Donald > --- > src/router.c | 6 -- > src/router.h | 23 ++- > 2 files changed, 26 insertions(+), 3 deletions(-

Re: [RFC PATCH 03/14] config: clamp ra_mininterval, ra_maxinterval, ra_lifetime at load time

On Fri, May 10, 2024 at 12:30:35AM +0200, Paul Donald wrote: > From: Paul Donald > > Signed-off-by: Paul Donald > --- > src/config.c | 48 +--- > src/router.c | 10 -- > src/router.h | 2 +- > 3 files changed, 42 insertions(+), 18 deletions(-

Re: [RFC PATCH 06/14] config: implement RFC4861 AdvValidLifetime (make configurable)

On Fri, May 10, 2024 at 12:30:38AM +0200, Paul Donald wrote: > From: Paul Donald > > In accordance with RFC4861. Enables control of ULA. > > The new config variable is valid_lifetime. e.g.: > > config dhcp 'lan' > ... > option valid_lifetime '6h' > Move this to separate series

Re: [RFC PATCH 01/14] config: refactor parse_leasetime() - branch amount remains same

On Fri, May 10, 2024 at 12:30:33AM +0200, Paul Donald wrote: > From: Paul Donald > > Also make 's' value a noop. > > Signed-off-by: Paul Donald > --- > src/config.c | 20 > 1 file changed, 8 insertions(+), 12 deletions(-) > > diff --git a/src/config.c b/src/config.c > ind