Re: Best practices for shell libraries (specifically error-checking)

2023-11-18 Thread reiner otto via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- ... * should a good library do

Best practices for shell libraries (specifically error-checking)

2023-11-18 Thread Philip Prindeville
Hi all, I'm trying to figure out what best practices are for shell libraries, as I'm working on changes to a pretty significant library which I envision being leveraged in a lot of places. My questions are these: * should a good library do error-checking for the caller, or expect the caller t

[PATCH v2] dnsmasq: mark global ubus context as closed after fork

2023-11-18 Thread Sven Eckelmann
++ daemon->ubus = NULL; +} + static int ubus_handle_metrics(struct ubus_context *ctx, struct ubus_object *obj, --- base-commit: 9062e5faaedc03823ee419fe34de1de73f48babc change-id: 20231118-dnsmasq_drop_ubus_null-69661a68d342 Best regards, -- Sven Eckelmann ___

Re: [PATCH] dnsmasq: mark global ubus context as closed after fork

2023-11-18 Thread Eric via openwrt-devel
patches/200-ubus_dns.patch > @@ -210,7 +210,7 @@ > + return; > + > + ubus_free(ubus); > -+ ubus = NULL; > ++ daemon->ubus = NULL; > > +} > + > static int ubus_handle_metrics(struct ubus_context *ctx, struct ubus_object > *obj, > > --- > base-co

[PATCH] dnsmasq: mark global ubus context as closed after fork

2023-11-18 Thread Sven Eckelmann
*obj, --- base-commit: 9062e5faaedc03823ee419fe34de1de73f48babc change-id: 20231118-dnsmasq_drop_ubus_null-ae5b5f062cb7 Best regards, -- Sven Eckelmann ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/