Re: [PATCH] rtl838x: clean up build instructions

Hi Adrian, On Tue, 2020-09-29 at 19:44 +0200, Adrian Schmutzler wrote: > > -define Build/custom-uimage > > - mkimage -A $(LINUX_KARCH) \ > > - -O linux -T kernel \ > > - -C gzip -a $(KERNEL_LOADADDR) $(if $(UIMAGE_MAGIC),-M > > $(UIMAGE_MAGIC),) \ > > - -e $(if > >

Re: [PATCH 4/5] initd: Don't search the environment list if the watchdog, fd is initialized

On 29.09.20 21:00, Michael Jones wrote: On Tue, Sep 29, 2020 at 1:59 PM John Crispin wrote: On 29.09.20 20:55, Michael Jones wrote: On Tue, Sep 29, 2020 at 1:47 PM John Crispin wrote: On 29.09.20 18:22, Michael Jones wrote: Signed-off-by: Michael Jones --- watchdog.c | 4 ++-- 1

Re: [PATCH 4/5] initd: Don't search the environment list if the watchdog, fd is initialized

On Tue, Sep 29, 2020 at 1:59 PM John Crispin wrote: > > > On 29.09.20 20:55, Michael Jones wrote: > > On Tue, Sep 29, 2020 at 1:47 PM John Crispin wrote: > >> > >> On 29.09.20 18:22, Michael Jones wrote: > >>> Signed-off-by: Michael Jones > >>> --- > >>>watchdog.c | 4 ++-- > >>>1 file ch

Re: [PATCH 4/5] initd: Don't search the environment list if the watchdog, fd is initialized

On 29.09.20 20:55, Michael Jones wrote: On Tue, Sep 29, 2020 at 1:47 PM John Crispin wrote: On 29.09.20 18:22, Michael Jones wrote: Signed-off-by: Michael Jones --- watchdog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/watchdog.c b/watchdog.c index 20830c3.

Re: [PATCH 4/5] initd: Don't search the environment list if the watchdog, fd is initialized

On Tue, Sep 29, 2020 at 1:47 PM John Crispin wrote: > > > On 29.09.20 18:22, Michael Jones wrote: > > Signed-off-by: Michael Jones > > --- > > watchdog.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/watchdog.c b/watchdog.c > > index 20830c3..ac5b656 100644

Re: [PATCH 4/5] initd: Don't search the environment list if the watchdog, fd is initialized

On 29.09.20 18:22, Michael Jones wrote: Signed-off-by: Michael Jones ---  watchdog.c | 4 ++--  1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/watchdog.c b/watchdog.c index 20830c3..ac5b656 100644 --- a/watchdog.c +++ b/watchdog.c @@ -49,11 +49,11 @@ static void watchdog_timeout

RE: [PATCH] rtl838x: clean up build instructions

Hi, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Sander Vanheule > Sent: Dienstag, 29. September 2020 18:20 > To: openwrt-devel@lists.openwrt.org > Cc: Sander Vanheule > Subject: [PATCH] rtl838x: clean up build instructions >

[PATCH 1/5] initd: Add ubus argument to trigger watchdog tickle.

Signed-off-by: Michael Jones ---  system.c | 5 +  1 file changed, 5 insertions(+) diff --git a/system.c b/system.c index 0fb98f1..ef7943a 100644 --- a/system.c +++ b/system.c @@ -325,6 +325,7 @@ enum { WDT_TIMEOUT, WDT_MAGICCLOSE, WDT_STOP, +    WDT_TICKLE, __WDT_MAX  };  

[PATCH 5/5] initd: Convert the watchdog_fd return value from char* to int

This change improves the frequently called path of determining if the watchdog is alive when responding to ubus transactions at the expense of complicating the less frequently called code of transitioning to the upgraded binary, and transitioning from pre-init to procd. Signed-off-by: Michael Jone

[PATCH 2/5] initd: Re-use the watchdog_set_cloexec() function from, watchdog_open()

Signed-off-by: Michael Jones ---  watchdog.c | 3 +--  1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/watchdog.c b/watchdog.c index 9d770b4..20b6e20 100644 --- a/watchdog.c +++ b/watchdog.c @@ -65,8 +65,7 @@ static int watchdog_open(bool cloexec) if (wdt_fd < 0)     return w

[PATCH 3/5] initd: Ensure that watchdog frequency changes apply right away

If the watchdog frequency is changed from high to low, the watchdog won't be tickled again until the previous period has expired, which may result in a watchdog timeout. This change ensures that the new frequency is applied immediately. Signed-off-by: Michael Jones ---  watchdog.c | 1 +  1 file c

[PATCH 4/5] initd: Don't search the environment list if the watchdog, fd is initialized

Signed-off-by: Michael Jones ---  watchdog.c | 4 ++--  1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/watchdog.c b/watchdog.c index 20830c3..ac5b656 100644 --- a/watchdog.c +++ b/watchdog.c @@ -49,11 +49,11 @@ static void watchdog_timeout_cb(struct uloop_timeout *t)    static int wa

[PATCH] rtl838x: clean up build instructions

The Device/Default recipe was defined, but never used. Move definitions that are not device-specific to Device/Default, and use it for allnet_all-sg8208m. This should make it more straightforward to add new devices. The modified uImage recipe can also be simplified, similar to how ath79/common-net

[PATCH 0/5] Improvements to the hardware watchdog code of procd

This set of patches makes various minor improvements to the hardware watchdog code of procd. The first patch adds a new feature to allow the watchdog to be manually tickled via ubus. The other patches are minor optimizations and improvements. Michael Jones (5):   initd: Add ubus argument to trig

Re: [PATCH] build, imagebuilder: Do not require compilers

On Sun Sep 27, 2020 at 11:07 AM HST, Sven Roederer wrote: > The buildroot and SDK both require the compilers (gcc, g++) to be > installed on the host system, however the ImageBuilder uses precompiled > binaries. > > This patch changes the prerequirements checks to skip the checking for > the compil