[PATCH 4/4] base-files/functions.sh: quote variables in []

2020-09-19 Thread Rosen Penev
ash does not support [[]] syntax, which makes this redundant. Found with https://github.com/koalaman/shellcheck/wiki/Sc2086 Signed-off-by: Rosen Penev --- package/base-files/files/lib/functions.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package/base-files/files/l

[PATCH 2/4] base-files/functions.sh: do not iterate over ls

2020-09-19 Thread Rosen Penev
>From https://github.com/koalaman/shellcheck/wiki/SC2045 : When looping over a set of files, it's always better to use globs when possible. Using command expansion causes word splitting and glob expansion, which will cause problems for certain filenames (typically first seen when trying to process

[PATCH 3/4] base-files/functions.sh: replace ^ with ! in []

2020-09-19 Thread Rosen Penev
Strictly speaking, ash does not support it. >From https://wiki.ubuntu.com/DashAsBinSh#A.5B.5E.5D : Not to be confused by sed's and other program's regular expression syntax. Uses of [^] in case (parameter/word expansion in general) need to be replaced with [!]. Found with shellcheck: https://git

[PATCH 1/4] base-files/functions.sh: read grep output by line

2020-09-19 Thread Rosen Penev
From: https://github.com/koalaman/shellcheck/wiki/SC2013 For loops by default (subject to $IFS) read word by word. Additionally, glob expansion will occur. I believe the intended use case of these loops is to read lines. Signed-off-by: Rosen Penev --- package/base-files/files/lib/functions.sh

RE: ath79: move 8/32 boards to tiny subtarget

2020-09-19 Thread Adrian Schmutzler
> Indeed "LOW_MEMORY_FOOTPRINT" seems only to affedt 3 general options > and one option of OpenSSL. > > So it might be an option to : > * set LOW_MEM for 8/32 MB devies > * set LOW_MEM and SMALL_FLASH for 4/32 MB devices > * check the CONFIG-options for usefull defaults So the tiny aubtarget can b

Re: ath79: move 8/32 boards to tiny subtarget

2020-09-19 Thread Sven Roederer
Hello David, Am Freitag, 18. September 2020, 09:44:10 CEST schrieb David Bauer: > Hello Sven, > > On 9/18/20 1:27 AM, Sven Roederer wrote: > > Adrian, David, > > > > Am Mittwoch, 16. September 2020, 16:15:42 CEST schrieb David Bauer: > >> Hi, > >> > >> On 9/16/20 11:40 AM, Adrian Schmutzler wro

Re: [PATCH] kernel: fix mtd partition erase

2020-09-19 Thread Thibaut
Hi, Thanks for the summary. I’m however under the impression that two distinct things are being confused here: partial erase and 4K_LIMIT. Specifically, prior to the recent (4.17) changes in the mtd subsystem, Mikrotik devices made use of two separate hacks: 1) the ability to set different EB

[PATCH v4 7/8] bcm53xx: add Cisco Meraki MR32

2020-09-19 Thread Christian Lamparter
This patch adds support for Cisco Meraki MR32. The unit was donated by Chris Blake. Thank you! WARNING: Only the 1x1:1 abgn Air Marshal WIPS wifi is currently supported by b43: b43-phy2: Found PHY: Analog 9, Type 4 (N), Revision 16 b43-phy2: Found Radio: Manuf 0x17F, ID 0x2057, Revision 9, Versi

[PATCH v4 1/8] scripts: mkits.sh make it possible to specify fdt@#

2020-09-19 Thread Christian Lamparter
Some bootloaders are really keen on just one special fdt in a multi-image fit image. This is a problem, because currently this is fixed to "fdt@1". This patch introduces a new device variable: DEVICE_FDT_NUM that allows to specify the right fdt number. If the value is absent "1" will be chosen.

[PATCH v4 6/8] kernel: package bcm53xx i2c module

2020-09-19 Thread Christian Lamparter
The BCM5301x SoCs do have i2c. Since this is only being used by the Meraki MR32, this will be packaged as a module. Signed-off-by: Christian Lamparter --- v3 -> v4 - moved to target/linux/bcm53xx/modules.mk --- target/linux/bcm53xx/modules.mk | 15 +++ 1 file changed, 15 ins

[PATCH v4 2/8] build: define PWM_SUPPORT arch feature flag

2020-09-19 Thread Christian Lamparter
As the PWM has its own sub-system in the Linux kernel, I think it should be handled in the same way as GPIO, RTC, PCI... This patch introduces a specific feature flag "pwm" and the "leds-pwm" kernel module as the first customer. Signed-off-by: Christian Lamparter --- package/kernel/linux/module

[PATCH v4 4/8] bcm53xx: backport uart2 and pcie2 device-nodes

2020-09-19 Thread Christian Lamparter
These have made their way into -next. This patch also includes the portion of the bcm53xx kernel patch refreshes as the hunks in 302-ARM-dts-BCM5301X-Update-Northstar-pinctrl-binding.patch moved slightly due to the added nodes. Signed-off-by: Christian Lamparter --- v2 -> v3 - backport pa

[PATCH v4 8/8] [RFT][WIP] bcm53xx: MR32: replace i2c-gpio with SoC's i2c

2020-09-19 Thread Christian Lamparter
During review of the MR32, Florian Fainelli pointed out that the SoC has a real I2C-controller. Furthermore, the connected pins (SDA and SCL) would line up perfectly for use. This patch swaps out the the bitbanged i2c-gpio with the real deal. It can be applied once it works. Signed-off-by: Christi

[PATCH v4 5/8] kernel: add default for new config symbols

2020-09-19 Thread Christian Lamparter
Provide disabled defaults for I2C_SLAVE_EEPROM and IPMB_DEVICE_INTERFACE. Signed-off-by: Christian Lamparter --- target/linux/generic/config-5.4 | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/linux/generic/config-5.4 b/target/linux/generic/config-5.4 index 6f63b8c5dd..1c28addff4 10

[PATCH v4 3/8] bcm53xx: enable PWM for bcm53xx

2020-09-19 Thread Christian Lamparter
The Meraki MR32 (BCM53016A1) uses the pwm to drive the tricolor LED. The driver has been available in upstream for a long time. Only the Device-Tree definition was missing, but it has been queued recently. Signed-off-by: Christian Lamparter --- v2 -> v3 - backport patches from devicetree/

Re: [PATCH] Fix tx-queue-size on NBG6817 (allows MTU changes).

2020-09-19 Thread Paul Oranje
See below, regards, Paul > Op 15 sep. 2020, om 21:56 heeft jacekow...@jacekowski.org het volgende > geschreven: The subject does not to comply with the rules for that, it should at least start with the target, better would be: ipq806x: fix tx-queue-size on NBG6817 > > From: Jacek Mile

Re: [PATCH v3 6/8] kernel: package bcm53xx i2c module

2020-09-19 Thread Christian Lamparter
On 2020-09-15 13:47, Daniel Golle wrote: On Tue, Sep 15, 2020 at 01:28:23PM +0200, Adrian Schmutzler wrote: Hi, -Original Message- From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On Behalf Of Christian Lamparter Sent: Samstag, 12. September 2020 23:16 To: openwrt-d

RE: [PATCH] kernel: fix mtd partition erase

2020-09-19 Thread Adrian Schmutzler
Hi, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of John Thomson > Sent: Mittwoch, 5. August 2020 23:14 > To: openwrt-devel@lists.openwrt.org > Cc: John Thomson > Subject: [PATCH] kernel: fix mtd partition erase wrong address > >