Op 23 jan. 2020, om 15:58 heeft Petr Štetiar het volgende
geschreven:
>
> On January 23, 2020 1:04:16 PM UTC, Paul Oranje wrote:
>
>> Suggestion: log of this unexpected condition or even stronger, an
>> assert().
>
> All logging is killed already, logging just to serial console won't cut it,
On January 23, 2020 1:04:16 PM UTC, Paul Oranje wrote:
>Suggestion: log of this unexpected condition or even stronger, an
>assert().
All logging is killed already, logging just to serial console won't cut it,
assert is overkill, which needs compiler flags/ifdef fiddling and who knows how
that
Adds feature to show exit code of processes launched by procd.
The exit code is shown for finished process when ubus's
service list method is called.
The exit code value is computed according to waitpid(2)
and http://tldp.org/LDP/abs/html/exitcodes.html
Signed-off-by: Ondřej Votava
---
service/
Adds feature to show exit code of processes launched by procd.
The exit code is shown for finished process when ubus's
service list method is called.
The exit code value is computed according to waitpid(2)
and http://tldp.org/LDP/abs/html/exitcodes.html
Signed-off-by: Ondřej Votava
---
service/
Adds feature to show exit code of processes launched by procd.
The exit code is shown for finished process when ubus's
service list method is called.
The exit code value is computed according to waitpid(2)
and http://tldp.org/LDP/abs/html/exitcodes.html
Signed-off-by: Ondřej Votava
---
service/
Op 23 jan. 2020, om 14:15 heeft ondrej.vot...@cvut.cz het volgende geschreven:
>
> +static int
> +instance_exit_code(int ret)
> +{
> + if(WIFEXITED(ret)) {
> + return WEXITSTATUS(ret);
> + }
> + else if (WIFSIGNALED(ret)) {
The else should be omitted because, when the previ
From: Ondřej Votava
Adds feature to show exit code of processes launched by procd.
The exit code is shown for finished process when ubus's
service list method is called.
The exit code value is computed according to waitpid(2)
and http://tldp.org/LDP/abs/html/exitcodes.html
Signed-off-by: Ondřej
On 23/01/2020 14:15, ondrej.vot...@cvut.cz wrote:
+static int
+instance_exit_code(int ret)
+{
+ if(WIFEXITED(ret)) {
^ missing space
+ return WEXITSTATUS(ret);
+ }
no new line here
+ else if (WIFSIGNALED(ret)) {
+ return 128 +
From: Ondřej Votava
Adds feature to show exit code of processes launched by procd.
The exit code is shown for finished process when ubus's
service list method is called.
The exit code value is computed according to waitpid(2)
and http://tldp.org/LDP/abs/html/exitcodes.html
Signed-off-by: Ondřej
Op 23 jan. 2020, om 10:28 heeft Petr Štetiar het volgende
geschreven:
>
> Paul Oranje [2020-01-22 11:09:22]:
>
> Hi,
>
> thanks for review.
>
>>> + if (is_container()) {
>>> + reboot(reboot_event);
>> When reboot returns, hasn't something gone wrong then ?
>
> What do you sugges
On 23/01/2020 13:58, ondrej.vot...@cvut.cz wrote:
+static int
+instance_exit_code(int ret){
+ if(WIFEXITED(ret))
+ {
+ return WEXITSTATUS(ret);
+ }
+ else if (WIFSIGNALED(ret))
+ {
+ return 128 + WTERMSIG(ret);
+ }
+ return 1;
From: Ondřej Votava
Adds feature to show exit code of processes launched by procd.
The exit code is shown for finished process when ubus's
service list method is called.
The exit code value is computed according to waitpid(2)
and http://tldp.org/LDP/abs/html/exitcodes.html
Signed-off-by: Ondřej
Op 22 jan. 2020, om 10:43 heeft Daniel Golle het
volgende geschreven:
>
> On Wed, Jan 22, 2020 at 06:34:06AM +0200, Daniel Golle wrote:
>> On Tue, Jan 21, 2020 at 11:34:22PM +0100, Mathias Kresin wrote:
>>> 21/01/2020 20:22, Daniel Golle:
On Tue, Jan 21, 2020 at 07:40:42PM +0100, Bjørn Mork
Paul Oranje [2020-01-22 11:09:22]:
Hi,
thanks for review.
> > + if (is_container()) {
> > + reboot(reboot_event);
> When reboot returns, hasn't something gone wrong then ?
What do you suggest?
I dont know how that behaves in all environments in order to answer that
question and I
Hi,
> This doesn't seem right to me in case target > 12,
> MIN(sizeof(line), strlen(target)) perhaps?
a simple strcmp() without len will be the most appropriate since both
line (produced by fgets()) and target (a constant string literal) will
be \0 terminated.
~ Jo
signature.asc
Description:
Rosen Penev writes:
> Several users have been reporting crashing issues with the ethernet
> driver.
>
> One source says that this is a silicon bug in mt7621:
> https://github.com/openwrt/mt76/issues/211#issuecomment-569687506
>
> A user that has been testing this has seen greater than 2-3 days up
16 matches
Mail list logo
