Re: [OpenWrt-Devel] [RFC] commit message in YAML format for new devices

2020-01-12 Thread Martin Blumenstingl via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- Hi Paul, On Sun, Jan 12, 2020 at

[OpenWrt-Devel] [PATCH libubox 1/4] tests: include json script shunit2 based testing

2020-01-12 Thread Petr Štetiar
Include shunit2 based tests into unit testing pipeline until (eventually) it's converted to cram based unit tests. Signed-off-by: Petr Štetiar --- tests/CMakeLists.txt |1 + tests/shunit2/CMakeLists.txt |7 + tests/shunit2/shunit2/shunit2 | 1040

[OpenWrt-Devel] [PATCH libubox 4/4] blobmsg: blobmsg_add_json_element() 64-bit values

2020-01-12 Thread Petr Štetiar
From: Dainis Jonitis libjson-c json_type_int values are stored as int64_t. Use json_object_get_int64() instead of json_object_get_int() to avoid clamping to INT32_MAX. Signed-off-by: Dainis Jonitis [fixed author to match SoB, added unit test results] Signed-off-by: Petr Štetiar --- blobmsg_js

[OpenWrt-Devel] [PATCH libubox 2/4] tests: blobmsg/json: add more test cases

2020-01-12 Thread Petr Štetiar
* add missing test with sanitizers * add test case for blobmsg_add_json_from_string * add test cases for all numeric types * print types for each variable Signed-off-by: Petr Štetiar --- tests/cram/test_blobmsg.t | 255 +++--- tests/test-blobmsg.c | 47 +

[OpenWrt-Devel] [PATCH libubox 3/4] blobmsg_json: fix int16 serialization

2020-01-12 Thread Petr Štetiar
int16 blobmsg type is currently being serialized as uint16_t due to missing cast during JSON output. Following blobmsg content: bar-min: -32768 (i16) bar-max: 32767 (i16) Produces following JSON: { "bar-min":32768,"bar-max":32767 } Whereas one would expect: { "bar-min":-32768,"bar-max":32

[OpenWrt-Devel] [PATCH libubox 0/4] more tests and fixes

2020-01-12 Thread Petr Štetiar
Hi, this patch series increases unit test coverage and fixes int16/int64 JSON serialization. Dainis Jonitis (1): blobmsg: blobmsg_add_json_element() 64-bit values Petr Štetiar (3): tests: include json script shunit2 based testing tests: blobmsg/json: add more test cases blobmsg_json: fix

Re: [OpenWrt-Devel] [RFC] commit message in YAML format for new devices

2020-01-12 Thread Daniel Gimpelevich
On Sun, 12 Jan 2020 11:47:29 -1000, Paul Spooren wrote: > All commits adding new devices already include most relevant information > for creating the overview. However it would be convenient if developers > would format their commit messages in a generic format, therefore I'd > propose the followin

[OpenWrt-Devel] [RFC] commit message in YAML format for new devices

2020-01-12 Thread Paul Spooren
Hi all, some time ago I created a (now outdated) device overview[0] based on YAML meta data. This approach could simplify maintaining an device overview and device specific pages[1]. All commits adding new devices already include most relevant information for creating the overview. However i

[OpenWrt-Devel] [PATCH] ath79: add support for D-Link DIR-505

2020-01-12 Thread David Bauer
This commit adds support for the D-Link DIR-505, previously supported in ar71xx. Hardware SoC: Atheros AR9330 FLASH: 8M SPI-NOR RAM: 64M WIFI: 1T1R 1SS Atheros AR9330 LED: Power green, Status red BTN: WPS, Reset Installation Currently, installation is only possible

Re: [OpenWrt-Devel] [PATCH] blobmsg: blobmsg_add_json_element() 64-bit values

2020-01-12 Thread Petr Štetiar
Dainis Jonitis [2020-01-10 16:41:04]: Hi, next time please make sure, that your From: match the Signed-off-by: -- I've fixed it this time. > libjson-c json_type_int values are stored as int64_t. Use > json_object_get_int64() instead of json_object_get_int() > to avoid clamping to INT32_MAX. >

[OpenWrt-Devel] [sdwalker/sdwalker.github.io] 38772e: This week's update

2020-01-12 Thread Stephen Walker
Branch: refs/heads/master Home: https://github.com/sdwalker/sdwalker.github.io Commit: 38772eae5e58f5b777a6981ce52618a20211de5c https://github.com/sdwalker/sdwalker.github.io/commit/38772eae5e58f5b777a6981ce52618a20211de5c Author: Stephen Walker Date: 2020-01-12 (Sun, 12 Jan 2

Re: [OpenWrt-Devel] [PATCH][libubox] blobmsg: blobmsg_parse and blobmsg_parse_array oob read fixes

2020-01-12 Thread Petr Štetiar
Petr Štetiar [2020-01-12 12:43:07]: > Those checks are run now automatically by CI after each Git push. I don't know if it's obvious how to use the tests/fuzzing inside libubox (and other C projects), so I've written something small[1] about the CI checks and used libubox as example. 1. http://

Re: [OpenWrt-Devel] [PATCH] [19.07] ramips: add kmod-mt7615e to Xiaomi Mi Router 3 Pro

2020-01-12 Thread mail
Hi Josef, > -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Josef Schlehofer > Sent: Sonntag, 12. Januar 2020 11:13 > To: openwrt-devel@lists.openwrt.org > Subject: [OpenWrt-Devel] [PATCH] [19.07] ramips: add kmod-mt7615e to > Xiaom

Re: [OpenWrt-Devel] [PATCH][libubox] blobmsg: blobmsg_parse and blobmsg_parse_array oob read fixes

2020-01-12 Thread Petr Štetiar
juraj.vijt...@sartura.hr [2020-01-12 12:26:18]: Hi, > @@ -35,10 +35,16 @@ static bool blobmsg_check_name(const struct blob_attr > *attr, size_t len, bool na > char *limit = (char *) attr + len; > const struct blobmsg_hdr *hdr; > > + if (len < sizeof(struct blob_attr) + sizeof(

Re: [OpenWrt-Devel] [PATCH][libubox] blobmsg: blobmsg_parse and blobmsg_parse_array oob read fixes

2020-01-12 Thread Petr Štetiar
juraj.vijt...@sartura.hr [2020-01-12 12:26:18]: Hi, thanks for the fix. > Fix out of bounds read in blobmsg_parse and blobmsg_check_name. The > out of bounds read happens because blob_attr and blobmsg_hdr have > flexible array members, whose size is 0 in the corresponding sizeofs. > For example

[OpenWrt-Devel] [PATCH][libubox] blobmsg: blobmsg_parse and blobmsg_parse_array oob read fixes

2020-01-12 Thread juraj . vijtiuk
Fix out of bounds read in blobmsg_parse and blobmsg_check_name. The out of bounds read happens because blob_attr and blobmsg_hdr have flexible array members, whose size is 0 in the corresponding sizeofs. For example the __blob_for_each_attr macro checks whether rem >= sizeof(struct blob_attr). Howe

[OpenWrt-Devel] [PATCH] [19.07] ramips: add kmod-mt7615e to Xiaomi Mi Router 3 Pro

2020-01-12 Thread Josef Schlehofer
From: Ozgur Can Leonard The package kmod-mt7615e was added to this router in the master branch [1] to have working Wi-Fi, but it is not included in OpenWrt 19.07. It was reported on OpenWrt forum [2] and tested that after installing this package Wi-Fi works. [1] https://github.com/openwrt/open