Re: [OpenWrt-Devel] [PATCH 1/4] PCI: add DT bindings for Faraday Technology PCI Host Bridge

2017-02-26 Thread Linus Walleij
On Wed, Feb 22, 2017 at 1:26 AM, Rob Herring wrote: > On Sat, Feb 11, 2017 at 01:52:17PM +0100, Linus Walleij wrote: >> +- compatible: should be one of >> + "faraday,pci" >> + "faraday,dual-pci" > > Probably should still have a Cortina specific compatible. OK I rewrote it using the specific-to

Re: [OpenWrt-Devel] [PATCH 2/4] PCI: add driver for Cortina Gemini Host Bridge

2017-02-26 Thread Linus Walleij
On Tue, Jan 31, 2017 at 1:37 AM, Bjorn Helgaas wrote: > Looks nice; a couple unused definitions below. Just so I do things right: what is your policy on unused defines? I'm asking because the defines in this case is pretty much the documentation... there is no datasheet for this IP core. I usua

Re: [OpenWrt-Devel] [PATCH] procd: service gets deleted when its last instance is freed

2017-02-26 Thread John Crispin
On 24/02/2017 11:21, Alin Năstac wrote: > Hi John, > > On Fri, Feb 24, 2017 at 10:53 AM, John Crispin wrote: >> can you write a little more info as to why this is needed and what >> scenario this fixes/changes ? > > 1) root@OpenWrt:~# uci show system.ntp > system.ntp=timeserver > system.ntp.en