[OpenWrt-Devel] Confirmed polarssl patch is unnecessary

2016-01-10 Thread Daniel Dickinson
I have confirmed that the issue that lead to my issuing the patch for polarssl download location is not an OpenWrt issue. That patch can be removed from Patchwork. Regards, Daniel ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https:

[OpenWrt-Devel] [PATCH] scripts/metadata: Allow to select which profiles to build

2016-01-10 Thread openwrt
From: Daniel Dickinson Certain platforms have large numbers of possible images, and it can be desirable to build neither all images nor only a single image, therefore this patch makes selecting target profiles a menu instead of a single choice, which allows the user to build a specific subset of

Re: [OpenWrt-Devel] Apologies

2016-01-10 Thread Daniel Dickinson
On 10/01/16 06:15 PM, Sami Olmari wrote: It might seem smallest of problems, but whitespace problems really causes an problems many times... "half of" stuff rely on correct You're right, and I think the reason I overreacted is that I have been subconsciously frustrated for quite some time by h

Re: [OpenWrt-Devel] Apologies

2016-01-10 Thread Sami Olmari
It might seem smallest of problems, but whitespace problems really causes an problems many times... "half of" stuff rely on correct spaces/spacing and so on, what takes spaces, what takes tabulator (take python for example), this is one reason why folks are quite anal about it. It's not because the

Re: [OpenWrt-Devel] [PATCH] package/libs/polarssl: Download location has moved and redirect is wrong

2016-01-10 Thread Daniel Dickinson
On 10/01/16 12:27 PM, Felix Fietkau wrote: > On 2016-01-10 08:10, open...@daniel.thecshore.com wrote: >> From: Daniel Dickinson >> >> Fix the download location to the new location of the source archive >> because the URI has change and redirect from the old URI is wrong >> Hmmm...looks like the

Re: [OpenWrt-Devel] [PATCH] fstools: Check FS state before writing

2016-01-10 Thread Felix Fietkau
On 2016-01-10 18:30, Felix Fietkau wrote: > On 2016-01-08 12:07, Wojciech Dubowik wrote: >> It reduces number of flash writes on systems with FS ready. >> >> Signed-off-by: Wojciech Dubowik > fs_state_set() already has such a check. And I just realized that I had apparently forgotten to actually

Re: [OpenWrt-Devel] [PATCH] fstools: Check FS state before writing

2016-01-10 Thread Felix Fietkau
On 2016-01-08 12:07, Wojciech Dubowik wrote: > It reduces number of flash writes on systems with FS ready. > > Signed-off-by: Wojciech Dubowik fs_state_set() already has such a check. - Felix ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.o

Re: [OpenWrt-Devel] [PATCH] package/libs/polarssl: Download location has moved and redirect is wrong

2016-01-10 Thread Felix Fietkau
On 2016-01-10 08:10, open...@daniel.thecshore.com wrote: > From: Daniel Dickinson > > Fix the download location to the new location of the source archive > because the URI has change and redirect from the old URI is wrong > > Signed-off-by: Daniel Dickinson > --- > package/libs/polarssl/Makefi

Re: [OpenWrt-Devel] [PATCH v2] ar8327: add IGMP Snooping support

2016-01-10 Thread Felix Fietkau
On 2016-01-10 17:07, Álvaro Fernández Rojas wrote: > This add support for IGMP Snooping on atheros switches (disabled by default), > which avoids flooding the network with multicast data. > > Tested on TL-WDR4300: disabling IGMP Snooping results in multicast flooding > on each specific port, enabl

Re: [OpenWrt-Devel] [PATCH] ar8327: add IGMP Snooping support

2016-01-10 Thread Álvaro Fernández Rojas
Hello Linus, You may find some documentation on what IGMP Snooping does in this Datasheet: https://lafibre.info/images/doc/201106_spec_AR8327.pdf However, I couldn't find any information regarding if it takes MRD into account. IGMPv3 support can be enabled or disabled independently. It does

[OpenWrt-Devel] [PATCH v2] ar8327: add IGMP Snooping support

2016-01-10 Thread Álvaro Fernández Rojas
This add support for IGMP Snooping on atheros switches (disabled by default), which avoids flooding the network with multicast data. Tested on TL-WDR4300: disabling IGMP Snooping results in multicast flooding on each specific port, enabling it back again prevents each port from receiving all multi

Re: [OpenWrt-Devel] Convincing vim on Fedora to highlight 'bad' whitespace

2016-01-10 Thread Daniel Dickinson
On 10/01/16 10:22 AM, Hartmut Knaack wrote: I think such information should go into a wiki article at dev.openwrt.org. Anybody starting development would more likely look there for information than searching through the mailing list (at least that is how I did it). Good point. I tend to forge

Re: [OpenWrt-Devel] Convincing vim on Fedora to highlight 'bad' whitespace

2016-01-10 Thread Hartmut Knaack
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Daniel Dickinson schrieb am 10.01.2016 um 16:01: > Hi all, > > While not strictly an OpenWrt topic, in the interests of helping other > with the style guidelines, here's a snipped for your $HOME/.vimrc > > The following is mostly from John Crispin

[OpenWrt-Devel] Convincing vim on Fedora to highlight 'bad' whitespace

2016-01-10 Thread Daniel Dickinson
Hi all, While not strictly an OpenWrt topic, in the interests of helping other with the style guidelines, here's a snipped for your $HOME/.vimrc The following is mostly from John Crispin, with one additional regex (for lines beginning with any number of sets of 8 spaces prior to non-whitespa

Re: [OpenWrt-Devel] never post cranky

2016-01-10 Thread Holger Levsen
Hi Daniel, don't worry too much, everybody has been on a wrong track at some time. OTOH, not everybody has realized that, so cheers to you! cheers, Holger signature.asc Description: This is a digitally signed message part. ___ openwrt-devel

[OpenWrt-Devel] never post cranky

2016-01-10 Thread Daniel Dickinson
Hi all, Sorry again about getting so upset about the whitespace thing. As much as it is irksome, it bothered me far too much. Life would be so much easier if I knew how to not give a damn, but then I probably wouldn't care about contributing to open source (or anything else involving more t

[OpenWrt-Devel] Apologies

2016-01-10 Thread Daniel Dickinson
Hi all, especially John, Sorry for all the mail about whitespace, it is just very frustrating when things that I don't see the value in, and which I've not had to worry about before, are the cause for rejection. I understand that whitespace inconsistencies are a problem for git, I also think

Re: [OpenWrt-Devel] [PATCH] base-files: For sysfixtime use hwclock if RTC available

2016-01-10 Thread Holger Levsen
Hi, On Sonntag, 10. Januar 2016, Daniel Dickinson wrote: > I had assumed it was automatic detection, (hence the comments about > Patchwork), not something someone has added as their own personal > excessively OCD-esque requirements. I follow this list very loosely (= I read the mails very quickly

Re: [OpenWrt-Devel] [PATCH] base-files: For sysfixtime use hwclock if RTC available

2016-01-10 Thread Daniel Dickinson
On 10/01/16 06:11 AM, John Crispin wrote: On 10/01/2016 11:32, Daniel Dickinson wrote: I'm sure this has been discussed to death, but having patchwork be a knob isn't the answer. at which point did patchwork get part of the equation ? I had assumed it was an automatic detection from a prog

Re: [OpenWrt-Devel] [PATCH] base-files: For sysfixtime use hwclock if RTC available

2016-01-10 Thread Daniel Dickinson
On 10/01/16 06:30 AM, Hartmut Knaack wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Daniel Dickinson schrieb am 10.01.2016 um 11:32: And yes you could make a regex that detect any sets of 8 spaces before non-whitespace text, but that seems like a lot of effort for no good reason, when n

Re: [OpenWrt-Devel] [PATCH] base-files: For sysfixtime use hwclock if RTC available

2016-01-10 Thread Hartmut Knaack
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Daniel Dickinson schrieb am 10.01.2016 um 11:32: > And yes you could make a regex that detect any sets of 8 spaces before > non-whitespace text, but that seems like a lot of effort for no good > reason, when not dealing with Makefiles. > > Anythin

Re: [OpenWrt-Devel] [PATCH 1/1] include/autotools.mk: rename libtool to libltdl

2016-01-10 Thread Felix Fietkau
On 2016-01-09 21:58, Heinrich Schuchardt wrote: > Fixes #21567 > > Since commit e49896f232ed2ed76f6a67cfb6c4f9bc3ac01af > package/libs/libtool: rename to libltdl > we see warnings like > > "WARNING: No feed for package 'libtool' found, maybe it's already part of > the standard packages?" > > for

Re: [OpenWrt-Devel] [PATCH] base-files: For sysfixtime use hwclock if RTC available

2016-01-10 Thread John Crispin
On 10/01/2016 11:32, Daniel Dickinson wrote: > I'm sure this has been discussed to death, but having patchwork be a > knob isn't the answer. at which point did patchwork get part of the equation ? i simple looked over the mails in my inbox in the morning and saw that there are 8 leading spaces

Re: [OpenWrt-Devel] [PATCH] base-files: For sysfixtime use hwclock if RTC available

2016-01-10 Thread Daniel Dickinson
And yes you could make a regex that detect any sets of 8 spaces before non-whitespace text, but that seems like a lot of effort for no good reason, when not dealing with Makefiles. Anything that applies a *hard* rule about whitespace is broken - whitespace shouldn't be getting converted unless

Re: [OpenWrt-Devel] [PATCH] base-files: For sysfixtime use hwclock if RTC available

2016-01-10 Thread Daniel Dickinson
Hi, On 10/01/16 05:10 AM, Gert Doering wrote: Hi, On Sun, Jan 10, 2016 at 04:47:05AM -0500, Daniel Dickinson wrote: I used git send-email so there shouldn't be any whitepspace mangling issues, unless patchwork is to blame. Over at openvpn-devel, we recently discovered that some versions of M

Re: [OpenWrt-Devel] [PATCH] base-files: For sysfixtime use hwclock if RTC available

2016-01-10 Thread Gert Doering
Hi, On Sun, Jan 10, 2016 at 04:47:05AM -0500, Daniel Dickinson wrote: > I used git send-email so there shouldn't be any whitepspace mangling > issues, unless patchwork is to blame. Over at openvpn-devel, we recently discovered that some versions of MS Exchange mangle whitespace for "mails in tra

Re: [OpenWrt-Devel] [PATCH] base-files: For sysfixtime use hwclock if RTC available

2016-01-10 Thread Daniel Dickinson
Ok, if this is one I just sent, that makes no sense; git does not report whitepace errors in git log -p, nor does the vim whitespace error detector you emailed me detect a whitespace error, locally. I used git send-email so there shouldn't be any whitepspace mangling issues, unless patchwork i

Re: [OpenWrt-Devel] [PATCH] base-files: For sysfixtime use hwclock if RTC available

2016-01-10 Thread John Crispin
On 10/01/2016 08:16, open...@daniel.thecshore.com wrote: > +else whitespace error > + local curtime="$(date +%s)" > + lo ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/m