[Openvpn-devel] [M] Change in openvpn[master]: dns option: make server id/priority optional

2023-09-12 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/40?usp=email ) Change subject: dns option: make server id/priority optional .. Patch Set 5:

[Openvpn-devel] [M] Change in openvpn[master]: dns option: make server id/priority optional

2023-09-12 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/40?usp=email ) Change subject: dns option: make server id/priority optional .. Pa

[Openvpn-devel] [M] Change in openvpn[master]: dns option: make server id/priority optional

2023-09-12 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has removed a vote from this change. ( http://gerrit.openvpn.net/c/openvpn/+/40?usp=email ) Change subject: dns option: make server id/priority optional ..

[Openvpn-devel] [XS] Change in openvpn[release/2.6]: buffer: use memcpy in buf_catrunc

2023-09-18 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/314?usp=email ) Change subject: buffer: use memcpy in buf_catrunc .. Patch Set 1: Code-Revie

[Openvpn-devel] [S] Change in openvpn[release/2.6]: Mock openvpn_exece on win32 also for test_tls_crypt

2023-09-18 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/313?usp=email ) Change subject: Mock openvpn_exece on win32 also for test_tls_crypt ...

[Openvpn-devel] [S] Change in openvpn[release/2.6]: Make cert_data.h and test_cryptoapi/pkcs11.c MSVC compliant

2023-09-18 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/312?usp=email ) Change subject: Make cert_data.h and test_cryptoapi/pkcs11.c MSVC compliant ..

[Openvpn-devel] [M] Change in openvpn[release/2.6]: vcpkg-ports/pkcs11-helper: Backport MinGW series from master to relea...

2023-09-18 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/311?usp=email ) Change subject: vcpkg-ports/pkcs11-helper: Backport MinGW series from master to release/2.6 .

[Openvpn-devel] [XL] Change in openvpn[release/2.6]: CMake: backport CMake buildsystem from master to release/2.6

2023-09-18 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/315?usp=email ) Change subject: CMake: backport CMake buildsystem from master to release/2.6 .

[Openvpn-devel] [S] Change in openvpn[release/2.6]: Mock openvpn_exece on win32 also for test_tls_crypt

2023-09-22 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/313?usp=email ) Change subject: Mock openvpn_exece on win32 also for test_tls_crypt .. Patch

[Openvpn-devel] [M] Change in openvpn[master]: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to Patch...

2023-09-25 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/361?usp=email ) Change subject: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to Patchwork

[Openvpn-devel] [S] Change in openvpn[master]: tun.c: don't attempt to delete DNS and WINS servers if they're not set

2023-12-16 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/482?usp=email ) Change subject: tun.c: don't attempt to delete DNS and WINS servers if they're not set

[Openvpn-devel] [XS] Change in openvpn[master]: cmake: build native binaries with debug info

2023-12-16 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/484?usp=email to review the following change. Change subject: cmake: build native binaries with debug info ...

[Openvpn-devel] [XS] Change in openvpn[master]: create and (sym)link compile_commands.json file

2023-12-16 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/483?usp=email to review the following change. Change subject: create and (sym)link compile_commands.json file

[Openvpn-devel] [XS] Change in openvpn[master]: cmake: create and link compile_commands.json file

2023-12-16 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/483?usp=email to look at the new patch set (#2). Change subject: cmake: create and link compile_commands.jso

[Openvpn-devel] [S] Change in openvpn[master]: tun.c: don't attempt to delete DNS and WINS servers if they're not set

2023-12-18 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/482?usp=email ) Change subject: tun.c: don't attempt to delete DNS and WINS servers if they're not set

[Openvpn-devel] [XS] Change in openvpn[master]: cmake: create and link compile_commands.json file

2023-12-18 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/483?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed

[Openvpn-devel] [XS] Change in openvpn[master]: cmake: build native binaries with debug info

2023-12-18 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/484?usp=email ) Change subject: cmake: build native binaries with debug info .. P

[Openvpn-devel] [XS] Change in openvpn[master]: cmake: build native binaries with debug info

2023-12-18 Thread d12fk (Code Review)
d12fk has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/484?usp=email ) Change subject: cmake: build native binaries with debug info .. Abandoned -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/484?usp=

[Openvpn-devel] [XS] Change in openvpn[master]: cmake: create and link compile_commands.json file

2023-12-19 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/483?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-01-08 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/489?usp=email to review the following change. Change subject: Windows: enforce 'block-local' with WFP filters

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-01-09 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/489?usp=email ) Change subject: Windows: enforce 'block-local' with WFP filters

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-01-09 Thread d12fk (Code Review)
Attention is currently required from: cron2, d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/489?usp=email to look at the new patch set (#2). The following approvals got outdated and were

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-01-09 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/489?usp=email ) Change subject: Windows: enforce 'block-local' with WFP filters

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-01-09 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/489?usp=email to look at the new patch set (#3). Change subject: Windows: enforce 'block-local' with

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-01-09 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/489?usp=email ) Change subject: Windows: enforce 'block-local' with WFP filters

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-01-09 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/489?usp=email to look at the new patch set (#4). Change subject: Windows: enforce 'block-local' with

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-01-10 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/489?usp=email ) Change subject: Windows: enforce 'block-local' with WFP filters .

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-01-10 Thread d12fk (Code Review)
Attention is currently required from: cron2, d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/489?usp=email to look at the new patch set (#5). Change subject: Windows: enforce 'block-local

[Openvpn-devel] [M] Change in openvpn[master]: cmake: symlink whole build dir not just .json file

2024-01-16 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/501?usp=email to review the following change. Change subject: cmake: symlink whole build dir not just .json fi

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-06-03 Thread d12fk (Code Review)
Attention is currently required from: cron2, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/489?usp=email ) Change subject: Windows: enforce 'block-local' with WFP filters .. Patch

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-06-03 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos, stipa. Hello cron2, flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/489?usp=email to look at the new patch set (#6). The following approvals got outd

[Openvpn-devel] [XS] Change in openvpn[master]: add and send IV_PROTO_DNS_OPTION_V2 flag

2024-07-24 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/680?usp=email to review the following change. Change subject: add and send IV_PROTO_DNS_OPTION_V2 flag ...

[Openvpn-devel] [M] Change in openvpn[master]: dns option: make server id/priority optional

2024-12-04 Thread d12fk (Code Review)
d12fk has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/40?usp=email ) Change subject: dns option: make server id/priority optional .. Abandoned optional server id would introduce yet another config incompatib

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

2024-12-04 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/824?usp=email to look at the new patch set (#2). Change subject: dns: support multiple domains without DHCP

[Openvpn-devel] [M] Change in openvpn[master]: dns: do not use netsh to set name server addresses

2024-12-04 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/825?usp=email to review the following change. Change subject: dns: do not use netsh to set name server address

[Openvpn-devel] [L] Change in openvpn[master]: dns: do not use netsh to set name server addresses

2024-12-04 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/825?usp=email to look at the new patch set (#2). Change subject: dns: do not use netsh to set name server ad

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

2024-12-04 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/824?usp=email to review the following change. Change subject: dns: support multiple domains without DHCP .

[Openvpn-devel] [L] Change in openvpn[master]: dns: do not use netsh to set name server addresses

2024-12-04 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/825?usp=email ) Change subject: dns: do not use netsh to set name server addresses .

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

2024-12-30 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/824?usp=email ) Change subject: dns: support multiple domains without DHCP .

[Openvpn-devel] [XL] Change in openvpn[master]: win: implement --dns option support

2024-12-30 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/837?usp=email ) Change subject: win: implement --dns option support .. Patch Set

[Openvpn-devel] [M] Change in openvpn[master]: dns: support running up/down script with privsep

2024-12-30 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/839?usp=email ) Change subject: dns: support running up/down script with privsep ..

[Openvpn-devel] [M] Change in openvpn[master]: dns: support running up/down script with privsep

2024-12-30 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/839?usp=email to look at the new patch set (#6). Change subject: dns: support running up/down script with pr

[Openvpn-devel] [M] Change in openvpn[master]: dns: support running up/down script with privsep

2024-12-11 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/839?usp=email to review the following change. Change subject: dns: support running up/down script with privsep

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2024-12-11 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email to review the following change. Change subject: dns: apply settings via script on unixoid system

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

2024-12-11 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/824?usp=email to look at the new patch set (#3). Change subject: dns: support multiple domains withou

[Openvpn-devel] [S] Change in openvpn[master]: service: add utf8to16 function that takes a size

2024-12-11 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/836?usp=email to review the following change. Change subject: service: add utf8to16 function that takes a size

[Openvpn-devel] [L] Change in openvpn[master]: dns: do not use netsh to set name server addresses

2024-12-11 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/825?usp=email to look at the new patch set (#3). The change is no longer submittable: checks~Ch

[Openvpn-devel] [L] Change in openvpn[master]: dns: don't publish env vars to non-dns scripts

2024-12-11 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/840?usp=email to review the following change. Change subject: dns: don't publish env vars to non-dns scripts .

[Openvpn-devel] [S] Change in openvpn[master]: dns: clone options via pointer instead of copy

2024-12-11 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/835?usp=email to review the following change. Change subject: dns: clone options via pointer instead of copy .

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

2024-12-11 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/824?usp=email ) Change subject: dns: support multiple domains without DHCP .

[Openvpn-devel] [XS] Change in openvpn[master]: dns: store IPv4 addresses in network byte order

2024-12-11 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/834?usp=email to review the following change. Change subject: dns: store IPv4 addresses in network byte order

[Openvpn-devel] [L] Change in openvpn[master]: dns: do not use netsh to set name server addresses

2024-12-22 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/825?usp=email to look at the new patch set (#5). The change is no longer submittable: checks~Ch

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2024-12-21 Thread d12fk (Code Review)
Attention is currently required from: d12fk, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email to look at the new patch set (#2). Change subject: dns: apply settings via script on unixoid systems

[Openvpn-devel] [S] Change in openvpn[master]: service: add utf8to16 function that takes a size

2024-12-21 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/836?usp=email ) Change subject: service: add utf8to16 function that takes a size ...

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

2024-12-21 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos, stipa. Hello flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/824?usp=email to look at the new patch set (#4). The following approvals got outdated an

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

2024-12-21 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/824?usp=email ) Change subject: dns: support multiple domains without DHCP .

[Openvpn-devel] [S] Change in openvpn[master]: service: add utf8to16 function that takes a size

2024-12-21 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/836?usp=email to look at the new patch set (#2). The following approvals got outdated and were

[Openvpn-devel] [L] Change in openvpn[master]: dns: don't publish env vars to non-dns scripts

2025-01-20 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/840?usp=email ) Change subject: dns: don't publish env vars to non-dns scripts ..

[Openvpn-devel] [L] Change in openvpn[master]: dns: support running up/down script with privsep

2025-01-20 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/839?usp=email ) Change subject: dns: support running up/down script with privsep ..

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

2025-01-13 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/824?usp=email ) Change subject: dns: support multiple domains without DHCP .

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-01-13 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email ) Change subject: dns: apply settings via script on unixoid systems .

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

2025-01-13 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos, stipa. Hello flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/824?usp=email to look at the new patch set (#8). The following approvals got outdated an

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-01-13 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-

[Openvpn-devel] [L] Change in openvpn[master]: dns: don't publish env vars to non-dns scripts

2025-01-13 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/840?usp=email to look at the new patch set (#7). Change subject: dns: don't publish env vars to non-dns scri

[Openvpn-devel] [L] Change in openvpn[master]: dns: do not use netsh to set name server addresses

2025-01-13 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/825?usp=email to look at the new patch set (#8). The change is no longer submittable: checks~Ch

[Openvpn-devel] [L] Change in openvpn[master]: dns: support running up/down script with privsep

2025-01-13 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/839?usp=email to look at the new patch set (#7). Change subject: dns: support running up/down script with pr

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

2024-12-23 Thread d12fk (Code Review)
Attention is currently required from: d12fk, plaisthos. Hello flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/824?usp=email to look at the new patch set (#6). Change subject: dns: support multiple domains without DHCP

[Openvpn-devel] [L] Change in openvpn[master]: dns: do not use netsh to set name server addresses

2024-12-23 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/825?usp=email to look at the new patch set (#6). The change is no longer submittable: checks~Ch

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

2024-12-23 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/824?usp=email ) Change subject: dns: support multiple domains without DHCP .. Pat

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

2024-12-23 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/824?usp=email to look at the new patch set (#7). Change subject: dns: support multiple domains withou

[Openvpn-devel] [L] Change in openvpn[master]: dns: do not use netsh to set name server addresses

2024-12-23 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/825?usp=email to look at the new patch set (#7). The change is no longer submittable: checks~Ch

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

2024-12-31 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/824?usp=email ) Change subject: dns: support multiple domains without DHCP .

[Openvpn-devel] [M] Change in openvpn[master]: Implement override-username

2025-02-26 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/872?usp=email ) Change subject: Implement override-username .. Patc

[Openvpn-devel] [L] Change in openvpn[master]: dns: don't publish env vars to non-dns scripts

2025-02-26 Thread d12fk (Code Review)
Attention is currently required from: d12fk, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/840?usp=email to look at the new patch set (#8). Change subject: dns: don't publish env vars to non-dns scripts ...

[Openvpn-devel] [L] Change in openvpn[master]: dns: do not use netsh to set name server addresses

2025-02-26 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/825?usp=email to look at the new patch set (#9). The change is no longer submittable: checks~Ch

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-02-26 Thread d12fk (Code Review)
Attention is currently required from: d12fk, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email to look at the new patch set (#8). Change subject: dns: apply settings via script on unixoid systems

[Openvpn-devel] [L] Change in openvpn[master]: dns: support running up/down script with privsep

2025-02-26 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/839?usp=email ) Change subject: dns: support running up/down script with privsep ..

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-02-26 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email ) Change subject: dns: apply settings via script on unixoid systems .

[Openvpn-devel] [M] Change in openvpn[master]: Implement override-username

2025-02-25 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/872?usp=email ) Change subject: Implement override-username .. Patc

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-03-03 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email ) Change subject: dns: apply settings via script on unixoid systems .

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-03-06 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email to look at the new patch set (#12). Change subject: dns: apply settings via script on unixoid

[Openvpn-devel] [M] Change in openvpn[master]: win: match search domains when creating exclude rules

2025-03-07 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/905?usp=email to review the following change. Change subject: win: match search domains when creating exclude

[Openvpn-devel] [S] Change in openvpn[master]: dns: clean up --dhcp-options when --dns is active

2025-03-06 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/904?usp=email to review the following change. Change subject: dns: clean up --dhcp-options when --dns is activ

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-03-06 Thread d12fk (Code Review)
Attention is currently required from: plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email ) Change subject: dns: apply settings via script on unixoid systems .. Patch Set

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-03-07 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email ) Change subject: dns: apply settings via script on unixoid systems .

[Openvpn-devel] [L] Change in openvpn[master]: dns: support running up/down script with privsep

2025-03-05 Thread d12fk (Code Review)
Attention is currently required from: d12fk, plaisthos. Hello MaxF, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/839?usp=email to look at the new patch set (#10). The change is no longer submittable: checks~ChecksSubmitRule

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-03-05 Thread d12fk (Code Review)
Attention is currently required from: d12fk, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email to look at the new patch set (#10). Change subject: dns: apply settings via script on unixoid systems

[Openvpn-devel] [L] Change in openvpn[master]: dns: do not use netsh to set name server addresses

2025-03-05 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/825?usp=email to look at the new patch set (#11). The change is no longer submittable: checks~C

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-03-06 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email ) Change subject: dns: apply settings via script on unixoid systems .

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

2025-03-06 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/824?usp=email ) Change subject: dns: support multiple domains without DHCP .

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

2025-03-06 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/824?usp=email ) Change subject: dns: support multiple domains without DHCP .

[Openvpn-devel] [L] Change in openvpn[master]: dns: do not use netsh to set name server addresses

2025-03-06 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/825?usp=email to look at the new patch set (#12). The change is no longer submittable: checks~C

[Openvpn-devel] [L] Change in openvpn[master]: dns: support running up/down script with privsep

2025-03-06 Thread d12fk (Code Review)
Attention is currently required from: MaxF, d12fk, plaisthos. Hello MaxF, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/839?usp=email to look at the new patch set (#11). The following approvals got outdated and were removed:

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-03-06 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email to look at the new patch set (#11). The following approvals got outdated and were removed: Code

[Openvpn-devel] [L] Change in openvpn[master]: dns: don't publish env vars to non-dns scripts

2025-03-06 Thread d12fk (Code Review)
Attention is currently required from: d12fk, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/840?usp=email to look at the new patch set (#11). Change subject: dns: don't publish env vars to non-dns scripts ..

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

2025-03-11 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos, stipa. Hello cron2, flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/824?usp=email to look at the new patch set (#13). The following approvals got out

[Openvpn-devel] [L] Change in openvpn[master]: dns: apply settings via script on unixoid systems

2025-03-11 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email ) Change subject: dns: apply settings via script on unixoid systems .

[Openvpn-devel] [L] Change in openvpn[master]: dns: don't publish env vars to non-dns scripts

2025-03-11 Thread d12fk (Code Review)
Attention is currently required from: cron2, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/840?usp=email ) Change subject: dns: don't publish env vars to non-dns scripts .. Patch

[Openvpn-devel] [L] Change in openvpn[master]: dns: support running up/down script with privsep

2025-03-11 Thread d12fk (Code Review)
Attention is currently required from: MaxF, d12fk, plaisthos. Hello MaxF, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/839?usp=email to look at the new patch set (#13). The change is no longer submittable: checks~ChecksSubm

[Openvpn-devel] [L] Change in openvpn[master]: dns: support multiple domains without DHCP

2025-03-11 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/824?usp=email ) Change subject: dns: support multiple domains without DHCP .

  1   2   >