Re: [Openvpn-devel] [PATCH] multi.c: Allow floating to a new IP right after connection setup

2025-04-28 Thread Walter Doekes via Openvpn-devel
> On 24-04-2025 10:26, Arne Schwabe wrote: > The code doesn't really do what the comment does. If you were trying to > actually figure out if it is the same client you should rather compare > the session ID of the tls state. As for the session_id, I checked the following: - m->session[TM_ACTIVE].

Re: [Openvpn-devel] [PATCH] multi.c: Allow floating to a new IP right after connection setup

2025-04-24 Thread Walter Doekes via Openvpn-devel
On 24-04-2025 10:26, Arne Schwabe wrote: I still do not really understanding what network setup you have to trigger this kind of bizzare behaviour of having a VPN connection. It would really be helpful if you can describe that more. Since the current explainations do not really explain for me wh

Re: [Openvpn-devel] [PATCH] multi.c: Allow floating to a new IP right after connection setup

2025-04-28 Thread Walter Doekes via Openvpn-devel
> On 24-04-2025 10:26, Arne Schwabe wrote: >> You are also saying that there is a difference in OpenVPN 2.5 vs OPneVPN >> 2.6. If that is indeed the case, a git bisect would be helpful to point >> to the commit that is breaking this. Well. This was my least worst bisect experience so far. So, than

[Openvpn-devel] [PATCH] multi.c: Allow floating to a new IP right after connection setup

2025-05-07 Thread Walter Doekes via Openvpn-devel
From: Walter Doekes When you're connected to a VPN which is used as the default gateway, a connection to a second VPN will cause a tunnel-in-tunnel traffic. If the administrator of the second VPN wants to avoid that, by pushing its IP as net_gateway, this means that the client's source IP switche

Re: [Openvpn-devel] [PATCH] multi.c: Allow floating to a new IP right after connection setup

2025-05-25 Thread Walter Doekes via Openvpn-devel
Good. Your understanding of the situation is the same. I did not yet make a reproducer config -- mostly because I don't think we're doing anything non-standard. But I did double check that latest 2.6 is affected, tested both client and server. And, I added some tracing code, and I observed th

Re: [Openvpn-devel] [PATCH] multi.c: Allow floating to a new IP right after connection setup

2025-05-22 Thread Walter Doekes via Openvpn-devel
> The thing is that I do not really understand your scenario and how it > exactly breaks for you to the extend that I cannot reproduce the issue. I thought I explained things sufficiently in: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31502.html Apparently not. Please le

Re: [Openvpn-devel] [PATCH] multi.c: Allow floating to a new IP right after connection setup

2025-05-22 Thread Walter Doekes via Openvpn-devel
Dear mailing list and Arne, I saw in the IRC meeting notes that 2.7 is about to be branched. I don't mean to push, but I personally think this bug is important enough to get looked at and fixed, preferably before 2.7.0 is made. Is this new patch good enough? Should I put it in Gerrit? Are there