[Openvpn-devel] [PATCH] Switch assertion failure to returning false

2020-05-20 Thread Jeremy Evans
`do_deferred_options` (`init.c`): Not this caller. The server configuration doesn't pull. Changing the assertion to returning false appears to be the simplest fix. Another approach would be changing callers to check `ks->authenticated` before calling, either `tls_session_update_crypto_param

Re: [Openvpn-devel] [PATCH] Switch assertion failure to returning false

2020-05-20 Thread Jeremy Evans
On 05/20 09:33, Gert Doering wrote: > Hi, > > On Wed, May 20, 2020 at 11:34:04AM -0700, Jeremy Evans wrote: > > To give some background, we hit this assertion failure, with the > > following log output: > > This should not happen, asserting out in "normal ser

Re: [Openvpn-devel] [PATCH] Switch assertion failure to returning false

2020-05-27 Thread Jeremy Evans
On 05/27 03:08, Steffan Karger wrote: > Hi, > > Thanks for the clear report, patch and follow-up. > > On 20-05-2020 23:31, Jeremy Evans wrote: > > On 05/20 09:33, Gert Doering wrote: > >> On Wed, May 20, 2020 at 11:34:04AM -0700, Jeremy Evans wrote: > >>