[Openvpn-devel] [PATCH] Warn that DH config option is only meaningful in a tls-server context

2017-08-27 Thread Gert van Dijk
If specified in a tls-client context, don't try to open the file as it's not used. Worse even, if 'none' was specified to disable explicitly, it complained that the file 'none' could not be found. --- src/openvpn/options.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/openvpn/opti

[Openvpn-devel] [PATCH 2/2] Add negotiated cipher to status file format 2 and 3

2017-11-11 Thread Gert van Dijk
With NCP turned off, this will still display the cipher used. Trac: #814 Signed-off-by: Gert van Dijk --- doc/openvpn.8 | 2 +- src/openvpn/multi.c | 11 +++ 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/doc/openvpn.8 b/doc/openvpn.8 index 267497fd..00dbff6f

[Openvpn-devel] [PATCH 1/2] manpage: improve description of --status and --status-version

2017-11-11 Thread Gert van Dijk
Signed-off-by: Gert van Dijk --- doc/openvpn.8 | 31 --- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git a/doc/openvpn.8 b/doc/openvpn.8 index a4189ac2..267497fd 100644 --- a/doc/openvpn.8 +++ b/doc/openvpn.8 @@ -2452,12 +2452,37 @@ seconds. Status can

Re: [Openvpn-devel] [PATCH] Implement "status 4" (JSON) for management interface

2017-11-11 Thread Gert van Dijk
Hi François, This is not a full review, but as just discussed face-to-face, here are some points from me: 1) Could we also please please enable this for non-management interface use case? I guess it's just adding the status version number 4 in option/config validator (and the manpage). 2) With 1)

[Openvpn-devel] [PATCH] Add generated openvpn.doxyfile to .gitignore

2017-11-11 Thread Gert van Dijk
I think this was omitted in 66bf378e. Signed-off-by: Gert van Dijk --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 18a45202..25009d81 100644 --- a/.gitignore +++ b/.gitignore @@ -52,6 +52,7 @@ config-msvc-version.h doc/openvpn.8.html /doc

Re: [Openvpn-devel] [PATCH 2/2] Add negotiated cipher to status file format 2 and 3

2017-11-12 Thread Gert van Dijk
Hi Arne, Thanks for reviewing this :) On 12-11-17 21:09, Arne Schwabe wrote: > Am 11.11.17 um 17:11 schrieb Gert van Dijk: >> With NCP turned off, this will still display the cipher used. >> >> Trac: #814 >> >> Signed-off-by: Gert van Dijk >> --- >>