Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1117?usp=email
to look at the new patch set (#3).
Change subject: mudp.c, multi.c, multi_io.c: get rid of "a
Attention is currently required from: cron2, flichtenheld, plaisthos.
ordex has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1117?usp=email )
Change subject: mudp.c, multi.c, multi_io.c: get rid of "all three DCO
platforms" #ifdefs
With commit b66b80b2a all three platforms with DCO support have DCO float
notifications now, so the #ifdef inside multi_process_incoming_dco() is
no longer needed.
Also, the whole notification block (process_incoming_del_peer() and
multi_process_incoming_dco()) was surrounded by an
#ifdef ENABL
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1117?usp=email
to look at the new patch set (#2).
Change subject: multi.c: get rid of #ifdef surrounding DCO
Thanks. Tested, works (and I already got chided for my lack of faith).
Uncrustify complained about whitespace conventions, so I've adjusted those
(whitespace-only, no code changes), and the patch did not apply "as is"
because Antonio changed a bit in dco_freebsd.h in the mean time so one
line of
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1117?usp=email
to review the following change.
Change subject: multi.c get rid of #ifdef surrounding DCO float
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1113?usp=email )
Change subject: management: resync timer on bytecount interval change
..
Attention is currently required from: cron2, plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1112?usp=email )
Change subject: options: Simplify function setenv_foreign_option
.
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1112?usp=email
to look at the new patch set (#2).
Change subject: options: Simplify function setenv_foreign_option
...
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1104?usp=email
to look at the new patch set (#2).
Change subject: ssl_common: Make sure ssl flags are treated as unsigned
..
add to test_search_and_replace.c to fix build error on
fedora 42 / arm64 ("error: uintptr_t undeclared")
Change-Id: I2ab13767b5aa858e024b45be3d161bf6090de763
Signed-off-by: Gert Doering
Acked-by: Frank Lichtenheld
---
This change was reviewed on Gerrit and approved by at least one
developer. I
Attention is currently required from: cron2, flichtenheld, stipa.
mrbff has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/808?usp=email )
Change subject: PUSH_UPDATE: Allow OpenVPN in client mode to receive and handle
PUSH UPDATE control messages to allow options updat
Attention is currently required from: cron2, flichtenheld, mrbff, stipa.
Hello cron2, flichtenheld, plaisthos, stipa,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/808?usp=email
to look at the new patch set (#22).
The following approvals got outdate
Attention is currently required from: cron2, plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1118?usp=email )
Change subject: unit_tests/plugins/auth-pam: fix stdint.h related build error
on fedora 42
..
It seems this would also affect feodora-42 on amd64, we just missed on
the "updates that bring in the breaking change" - but now we are prepared ;-)
Patch has been applied to the master branch.
commit 035d47e6d80996a4cde8af1b35f9ba40b676c825
Author: Gert Doering
Date: Mon Jul 28 12:42:29 2025 +
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/1118?usp=email )
Change subject: unit_tests/plugins/auth-pam: fix stdint.h related build error
on fedora 42
..
unit_tests/plugins/auth-pam: fix stdint.h r
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1118?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld
Change subject: unit_tests/plugins/a
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1067?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review-1 b
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1118?usp=email
to review the following change.
Change subject: unit_tests/plugins/auth-pam: fix stdint.h relat
Hello flichtenheld, ordex, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1117?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+2 by ordex
Change subject: mudp.c, multi.c, mul
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/1117?usp=email )
Change subject: mudp.c, multi.c, multi_io.c: get rid of 'all three DCO
platforms' #ifdefs
..
mudp.c, multi.c, multi_io.c: get rid of 'all
Just for reference: we saw quite a few build errors in BB, but these are
due to "fedora 42 on arm 64" (only!) being different about ,
which is addressed in gerrit #1118. Unrelated to any recent patch.
Patch has been applied to the master branch.
commit 6d0e38370b62488374a09336652ab415776955fc
A
Attention is currently required from: cron2, flichtenheld, plaisthos.
ordex has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1116?usp=email )
Change subject: dco: drop client prefix after DCO PEER_FLOAT notification
.
Attention is currently required from: cron2, flichtenheld, plaisthos.
ordex has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1116?usp=email )
Change subject: dco: drop client prefix after DCO PEER_FLOAT notification
.
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1112?usp=email )
Change subject: options: Simplify function setenv_foreign_option
.
From: Frank Lichtenheld
This was relatively complex for the actual usage.
Looked at the code because of -Wconversion warnings
related to the len argument. So this should also be
gone.
Change-Id: I7efc77f63734501dfa8a8f5bed17b1a1b4e9e201
Signed-off-by: Frank Lichtenheld
Acked-by: Gert Doering
-
cron2 has uploaded a new patch set (#4) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1112?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: options: Simplify function setenv_foreign_option
.
Stared at code (simple is good ;-) ). Tested with manually connecting
to a server that pushes --dns and --dhcp-option (DNS and others),
and verifying the output before/after. Same.
Your patch has been applied to the master branch.
commit 654671a10b8f26ed0041ce434016fecb11438aae
Author: Frank L
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/1112?usp=email )
Change subject: options: Simplify function setenv_foreign_option
..
options: Simplify function setenv_foreign_option
This was relatively
29 matches
Mail list logo
