[Openvpn-devel] [PATCH v2] dco_linux: use M_FATAL instead of M_ERR in netlink error code paths

From: Antonio Quartulli Netlink code doesn't set errno upon error (with the exception of any *alloc() function which probably inherits the errno=ENOMEM from the underlying malloc call), therefore we should not print error messages with M_ERR, but rather rely on M_FATAL. M_ERR is equivalent to M_

[Openvpn-devel] [PATCH v2] dco_linux: fix case statement by using proper error value

From: Antonio Quartulli A M_ERR constant accidentally slipped in as possible netlink error value. Substitute it with the actual code matching the following error message. Change-Id: I18df6ef659cab9525dd7847b7dd3950fc1895dd5 Signed-off-by: Antonio Quartulli Acked-by: Gert Doering --- This cha

[Openvpn-devel] [S] Change in openvpn[master]: dco_linux: use M_FATAL instead of M_ERR in netlink error code paths

Attention is currently required from: flichtenheld, ordex, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1096?usp=email ) Change subject: dco_linux: use M_FATAL instead of M_ERR in netlink error code paths ..

[Openvpn-devel] [S] Change in openvpn[release/2.6]: GHA: Update dependencies July 2025 (2.6)

Attention is currently required from: flichtenheld, plaisthos. uddr has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1080?usp=email ) Change subject: GHA: Update dependencies July 2025 (2.6) .. Patch

[Openvpn-devel] [S] Change in openvpn[master]: GHA: Dependency updates July 2025

Attention is currently required from: flichtenheld, plaisthos. uddr has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1079?usp=email ) Change subject: GHA: Dependency updates July 2025 .. Patch Set 3:

[Openvpn-devel] [S] Change in openvpn[master]: Fix socketpair return status not being checked in port share code

Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/770?usp=email ) Change subject: Fix socketpair return status not being checked in port share code ...

[Openvpn-devel] [S] Change in openvpn[master]: GHA: Dependency updates July 2025

Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, uddr, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1079?usp=email to look at the new patch set (#4). The change is no longer submittable: checks~ChecksSubmitRule is uns

[Openvpn-devel] [S] Change in openvpn[master]: GHA: Dependency updates July 2025

Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, uddr, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1079?usp=email to look at the new patch set (#5). The change is no longer submittable: checks~ChecksSubmitRule is uns

[Openvpn-devel] [S] Change in openvpn[release/2.6]: GHA: Update dependencies July 2025 (2.6)

Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, uddr, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1080?usp=email to look at the new patch set (#2). The change is no longer submittable: checks~ChecksSubmitRule is uns

[Openvpn-devel] [M] Change in openvpn[master]: Check message id/acked ids too when doing sessionid cookie checks

Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1067?usp=email ) Change subject: Check message id/acked ids too when doing sessionid cookie checks ..

[Openvpn-devel] [PATCH applied] Re: GHA: Dependency updates July 2025

Tested on my GH repo, all fine. ACKed by the build master :-) Your patch has been applied to the master branch. commit 48f4a6a56189703073e1282a1a252e0bd8d9b05d Author: Frank Lichtenheld Date: Tue Jul 22 12:27:18 2025 +0200 GHA: Dependency updates July 2025 Signed-off-by: Frank Lich

[Openvpn-devel] [S] Change in openvpn[master]: GHA: Dependency updates July 2025

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1079?usp=email ) Change subject: GHA: Dependency updates July 2025 .. GHA: Dependency updates July 2025 chore(deps): update dependency aws/aws-lc to v1.55

[Openvpn-devel] [S] Change in openvpn[master]: GHA: Dependency updates July 2025

cron2 has uploaded a new patch set (#6) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1079?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by uddr Change subject: GHA: Dependency updates July 2025 .

[Openvpn-devel] [PATCH applied] Re: GHA: Update dependencies July 2025 (2.6)

Tested on my GH repo, all green. ACKed by the build master. Your patch has been applied to the release/2.6 branch. commit 744b7d20d70b956279c63404bcb8b5004b41216e Author: Frank Lichtenheld Date: Tue Jul 22 12:28:10 2025 +0200 GHA: Update dependencies July 2025 (2.6) Signed-off-by:

[Openvpn-devel] [S] Change in openvpn[release/2.6]: GHA: Update dependencies July 2025 (2.6)

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1080?usp=email ) Change subject: GHA: Update dependencies July 2025 (2.6) .. GHA: Update dependencies July 2025 (2.6) Pin dependencies chore(deps): update

[Openvpn-devel] [S] Change in openvpn[release/2.6]: GHA: Update dependencies July 2025 (2.6)

cron2 has uploaded a new patch set (#3) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1080?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by uddr Change subject: GHA: Update dependencies July 2025 (2.6) ..

[Openvpn-devel] [L] Change in openvpn[master]: dco_linux: factor out netlink notification code

Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1099?usp=email to review the following change. Change subject: dco_linux: factor out netlink notification code

[Openvpn-devel] [L] Change in openvpn[master]: dco_linux: rearrange functions

Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1098?usp=email to review the following change. Change subject: dco_linux: rearrange functions

[Openvpn-devel] [M] Change in openvpn[master]: dco_linux: fix async message reception

Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1100?usp=email to review the following change. Change subject: dco_linux: fix async message reception

[Openvpn-devel] [XS] Change in openvpn[master]: add context to dco-linux.h

Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1097?usp=email to review the following change. Change subject: add context to dco-linux.h

[Openvpn-devel] [S] Change in openvpn[master]: dco: only pass struct context to init function

Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1094?usp=email to review the following change. Change subject: dco: only pass struct context to init function

[Openvpn-devel] [S] Change in openvpn[master]: dco_linux: use M_FATAL instead of M_ERR in netlink error code paths

Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1096?usp=email to review the following change. Change subject: dco_linux: use M_FATAL instead of M_ERR in netl

[Openvpn-devel] [XS] Change in openvpn[master]: dco_linux: fix case statement by using proper error value

Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1095?usp=email to review the following change. Change subject: dco_linux: fix case statement by using proper e

[Openvpn-devel] [S] Change in openvpn[master]: dco: only pass struct context to init function

Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1094?usp=email to look at the new patch set (#2). Change subject: dco: only pass struct context to init func

[Openvpn-devel] [XS] Change in openvpn[master]: add context to dco-linux.h

ordex has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/1097?usp=email ) Change subject: add context to dco-linux.h .. Abandoned this was supposed to be merged with another commit -- To view, visit http://gerr

[Openvpn-devel] [S] Change in openvpn[master]: multi: store multi_context address inside top instance

Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1093?usp=email to review the following change. Change subject: multi: store multi_context address inside top i

[Openvpn-devel] [PATCH v2] dco_linux: rearrange functions

From: Antonio Quartulli In preparation for the implementation of a generic netlink message parser, move all parsing functions above ovpn_handle_msg(). The latter is soon going to become a generic message parser which will invoke specific handlers, thus they are required to be defined earlier in

[Openvpn-devel] [L] Change in openvpn[master]: dco_linux: rearrange functions

Attention is currently required from: flichtenheld, ordex, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1098?usp=email ) Change subject: dco_linux: rearrange functions .. Patch S

[Openvpn-devel] [PATCH v1] multi: store multi_context address inside top instance

From: Antonio Quartulli Future modifications to DCO require accessing the server multi_context object. Since it is currently a stack variable that is pointed by no one, we'd need to pass it to all kind of functions to ensure it can reach the DCO code. To make the implementation simpler, it is p

[Openvpn-devel] [S] Change in openvpn[master]: multi: store multi_context address inside top instance

Attention is currently required from: flichtenheld, ordex, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1093?usp=email ) Change subject: multi: store multi_context address inside top instance

[Openvpn-devel] [S] Change in openvpn[master]: dco: only pass struct context to init function

Attention is currently required from: flichtenheld, ordex, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1094?usp=email ) Change subject: dco: only pass struct context to init function

[Openvpn-devel] [XS] Change in openvpn[master]: dco_linux: fix case statement by using proper error value

Attention is currently required from: flichtenheld, ordex, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1095?usp=email ) Change subject: dco_linux: fix case statement by using proper error value .

Re: [Openvpn-devel] [M] Change in openvpn[master]: Check message id/acked ids too when doing sessionid cookie checks

Anything I can do to get this moving along? Cheers, Walter On 26-06-2025 10:14, plaisthos (Code Review) wrote: Attention is currently required from: flichtenheld. plaisthos *uploaded patch set #3* to this change. View Change Check messa

[Openvpn-devel] [PATCH v5] GHA: Dependency updates July 2025

chore(deps): update dependency aws/aws-lc to v1.55.0 chore(deps): update lukka/get-cmake action to v4.0.3 chore(deps): update vcpkg digest to f33cc49 chore(deps): update dependency mbed-tls/mbedtls to v3.6.4 Change-Id: I615cc12c4f299a2a48db24bc7379ac6c5921 Signed-off-by: Frank Lichtenheld Ack

[Openvpn-devel] [PATCH v2] GHA: Update dependencies July 2025 (2.6)

Pin dependencies chore(deps): update lukka/get-cmake action to v4 chore(deps): update vcpkg digest to f33cc49 Change-Id: I46177b0614ad8b167a421c50d3cc8e7da4054e42 Signed-off-by: Frank Lichtenheld Acked-by: Yuriy Darnobyt --- This change was reviewed on Gerrit and approved by at least one develo