From: Ralf Lici
Extend the log message printed when an instance floats to an address
already taken by another instance with the same certificate. The updated
message now includes the instance being closed, the reason it's being
closed, and the new instance taking over that address.
Change-Id: I2
Attention is currently required from: cron2, flichtenheld, plaisthos.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1092?usp=email
to look at the new patch set (#2).
Change subject: add flag to print addresses in a co
Attention is currently required from: flichtenheld, plaisthos, ralf_lici.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1092?usp=email )
Change subject: add flag to print mroute_addr address family
..
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/1091?usp=email )
Change subject: improve float collision logging
..
improve float collision logging
Extend the log message printed when an instance floats
cron2 has uploaded a new patch set (#2) to the change originally created by
ralf_lici. ( http://gerrit.openvpn.net/c/openvpn/+/1091?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: improve float collision logging
.
Just a small commit but would have saved us a few hours staring at logs
today - due to a different bug, the floating code would try to "float to
itself", find "that ip+port is already in use", kill 'that' instance
(itself), and then crash on "where did my instance go?"... and we just
got an ominou
Attention is currently required from: cron2, flichtenheld, plaisthos.
ralf_lici has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1092?usp=email )
Change subject: add flag to print mroute_addr address family
..
Attention is currently required from: flichtenheld, ordex, plaisthos,
ralf_lici, stipa.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1084?usp=email )
Change subject: dco: Add support for float notifications
...
From: Ralf Lici
When a peer changes its UDP endpoint, the DCO module emits a
notification to userpace. The message is parsed and the relevant
information are extracted in order to process the floating operation.
Note that we preserve IPv4-mapped IPv6 addresses in userspace when
receiving a pure
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1091?usp=email
to review the following change.
Change subject: improve float collision logging
...
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1092?usp=email
to review the following change.
Change subject: add flag to print mroute_addr address family
..
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1090?usp=email
to review the following change.
Change subject: Fix broken DHCP options
...
On 14/07/2025 16:20, Sabrina Dubroca wrote:
In ovpn_nl_key_swap_doit, the attributes array used to parse the
OVPN_A_KEYCONF uses OVPN_A_PEER_MAX instead of
OVPN_A_KEYCONF_MAX. Note that this does not cause any bug, since
currently OVPN_A_KEYCONF_MAX < OVPN_A_PEER_MAX.
Fixes: 203e2bf55990 ("ovpn:
Attention is currently required from: flichtenheld, plaisthos, ralf_lici, stipa.
ordex has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1084?usp=email )
Change subject: dco: Add support for float notifications
...
Attention is currently required from: flichtenheld, ordex, plaisthos,
ralf_lici, stipa.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1084?usp=email )
Change subject: dco: Add support for float notifications
...
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/1084?usp=email )
Change subject: dco: Add support for float notifications
..
dco: Add support for float notifications
When a peer changes its UDP endpoint
So, this was quite a bit of work from the already-+2'ed v3 :-)
The patch looks larger than it actually is, because it affects the
two low level DCO modules implemented plus the "midlayer" having to
update the peer address. Each individual change is fairly straightforward.
I have stared at the cod
cron2 has uploaded a new patch set (#7) to the change originally created by
ralf_lici. ( http://gerrit.openvpn.net/c/openvpn/+/1084?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2, Code-Review+2 by ordex
Change subject: dco: Add support for float notifi
Attention is currently required from: flichtenheld, ordex, plaisthos,
ralf_lici, stipa.
Hello cron2, flichtenheld, ordex, plaisthos, stipa,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1084?usp=email
to look at the new patch set (#6).
Change subj
From: Gianmarco De Gregori
Fixed a bug where clients using different transport
protocols (UDP, TCP) could interfere with each other
after a server restart.
The issue occurred when a client reused a previously
assigned peer-id that was now associated with a
different client using a different trans
Attention is currently required from: flichtenheld, its_Giaan, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1078?usp=email )
Change subject: Multi-socket: Fix assert triggered by stale peer-id reuse
.
So, while I could not trigger the original ASSERT() (GH issue #773) I
was able to trigger "server misbehaviour" (TCP client with peer-id #0
being kicked out when a leftover UDP client with (old) peer-id #0 sent
data packets). With the patch, these are gone.
The explanation makes sense - when chec
cron2 has uploaded a new patch set (#4) to the change originally created by
its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/1078?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: Multi-socket: Fix assert triggered by stale peer-id reuse
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/1078?usp=email )
Change subject: Multi-socket: Fix assert triggered by stale peer-id reuse
..
Multi-socket: Fix assert triggered by stale peer-id reuse
Fi
Attention is currently required from: flichtenheld, plaisthos, ralf_lici.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1091?usp=email )
Change subject: improve float collision logging
..
Pa
25 matches
Mail list logo
