[Openvpn-devel] [M] Change in openvpn[master]: reliable: Review and fix gc_arena usage

2025-07-11 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1083?usp=email ) Change subject: reliable: Review and fix gc_arena usage .. Patch Set 3:

[Openvpn-devel] [PATCH v3] move macOS dns-updown common code into functions

2025-07-11 Thread Frank Lichtenheld
From: Heiko Hund Change-Id: Id6f70237c7205063b001528a40391678b0d093ac Signed-off-by: Heiko Hund Acked-by: Frank Lichtenheld --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1074 T

[Openvpn-devel] [PATCH v2] Do not compile mbed key helper with MBEDTLS_SSL_KEYING_MATERIAL_EXPORT

2025-07-11 Thread Frank Lichtenheld
From: Arne Schwabe The helper methods are only used when we don't have MBEDTLS_SSL_KEYING_MATERIAL_EXPORT and mbedtls_ssl_export_keying_material. Change-Id: I0f325800ebeb20bd5ef3ff78e5c5fcf0f6f74efd Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld --- This change was reviewed on Gerrit

[Openvpn-devel] [PATCH v1] Fix compiler warning in reliable.c with --disable-debug

2025-07-11 Thread Frank Lichtenheld
Use the easy way out. Using pre-compiler to completely avoid n_active seems like overkill. Change-Id: Icad1a52d14311a6f06bda081cab2f4bded8d47ed Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe --- This change was reviewed on Gerrit and approved by at least one developer. I request to mer

[Openvpn-devel] [PATCH v4] mac dns: do not run dns-updown in parallel

2025-07-11 Thread Frank Lichtenheld
From: Heiko Hund In case more than one openvpn connection is coming up or going down at the same time, there is potential for breakage, since the operations performed are not atomic. Introduce a locking mechanism, which let's scripts run in sequence, to prevent races between them. Change-Id: I7

[Openvpn-devel] [PATCH v4] mac dns: compare servers before restoring backup

2025-07-11 Thread Frank Lichtenheld
From: Heiko Hund In case anything changed the global DNS server addresses, while the tunnel was connected, do not restore the backup of the global DNS configuration we made when connecting. Doing so would likely change DNS to something unexpected. Instead just clear the backup and leave a message

[Openvpn-devel] [S] Change in openvpn[master]: mac dns: compare servers before restoring backup

2025-07-11 Thread flichtenheld (Code Review)
Attention is currently required from: d12fk, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1075?usp=email ) Change subject: mac dns: compare servers before restoring backup .