[Openvpn-devel] [S] Change in openvpn[master]: Fix new doxygen warnings about using @return in void functions

2025-07-02 Thread flichtenheld (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos. Hello ordex, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1029?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code

[Openvpn-devel] [S] Change in openvpn[master]: Fix new doxygen warnings about using @return in void functions

2025-07-02 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1029?usp=email ) Change subject: Fix new doxygen warnings about using @return in void functions ...

[Openvpn-devel] IRC community meeting summary

2025-07-02 Thread Johan Draaisma
Meeting summary for 2 July 2025: * *New: cve.mitre.org deprecation notice* The MITRE CVE site we are linking to for all CVE record references has a deprecation notice. Instead cve.org is being advised as the site to use from now on. Suggestion from novaflash is to search/replace

[Openvpn-devel] [PATCH v2] Fix new doxygen warnings about using @return in void functions

2025-07-02 Thread Gert Doering
From: Frank Lichtenheld These seem to have been added in a more recent doxygen version than I previously tested with. Change-Id: Ia2b3eda18bd6dbce6c470037c7a01097e8147c29 Signed-off-by: Frank Lichtenheld Acked-by: Antonio Quartulli --- This change was reviewed on Gerrit and approved by at lea

[Openvpn-devel] [S] Change in openvpn[master]: Fix new doxygen warnings about using @return in void functions

2025-07-02 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1072?usp=email to review the following change. Change subject: Fix new doxygen warnings about using @return in void functions

[Openvpn-devel] [S] Change in openvpn[master]: Fix new doxygen warnings about using @return in void functions

2025-07-02 Thread flichtenheld (Code Review)
flichtenheld has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/1072?usp=email ) Change subject: Fix new doxygen warnings about using @return in void functions .. Abandoned duplicate -- To view, visit http://ge

[Openvpn-devel] [S] Change in openvpn[master]: Fix new doxygen warnings about using @return in void functions

2025-07-02 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1029?usp=email ) Change subject: Fix new doxygen warnings about using @return in void functions ..

[Openvpn-devel] [S] Change in openvpn[master]: Fix new doxygen warnings about using @return in void functions

2025-07-02 Thread ordex (Code Review)
Attention is currently required from: flichtenheld. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1029?usp=email ) Change subject: Fix new doxygen warnings about using @return in void functions ..

[Openvpn-devel] [S] Change in openvpn[master]: Fix new doxygen warnings about using @return in void functions

2025-07-02 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#3) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1029?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by ordex Change subject: Fix new doxygen warnings about using @return in void f

[Openvpn-devel] [PATCH applied] Re: Fix new doxygen warnings about using @return in void functions

2025-07-02 Thread Gert Doering
Not much for me to test - only doxygen comments are changed, and Arne/Antonio have reviewed these. Your patch has been applied to the master branch. commit c18a995d0e6752575299a750539acd5e35115846 Author: Frank Lichtenheld Date: Wed Jul 2 17:04:27 2025 +0200 Fix new doxygen warnings about

[Openvpn-devel] [S] Change in openvpn[master]: Fix new doxygen warnings about using @return in void functions

2025-07-02 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1029?usp=email ) Change subject: Fix new doxygen warnings about using @return in void functions .. Fix new doxygen warnings about using @return in void fun

[Openvpn-devel] [M] Change in openvpn[master]: prevent search domain races with macOS dns-updown

2025-07-02 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1073?usp=email to review the following change. Change subject: prevent search domain races with macOS dns-updo

[Openvpn-devel] [S] Change in openvpn[master]: mac dns: do not run dns-updown in parallel

2025-07-02 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1076?usp=email to review the following change. Change subject: mac dns: do not run dns-updown in parallel

[Openvpn-devel] [M] Change in openvpn[master]: move macOS dns-updown common code into functions

2025-07-02 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1074?usp=email to review the following change. Change subject: move macOS dns-updown common code into function

[Openvpn-devel] [S] Change in openvpn[master]: mac dns: compare servers before restoring backup

2025-07-02 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1075?usp=email to review the following change. Change subject: mac dns: compare servers before restoring backu