[Openvpn-devel] [PATCH applied] Re: run forced --dns-updown without --script-security

2025-06-28 Thread Gert Doering
Thanks for addressing this imbalance wrt --script-security - I have not tested the various combinations, just --dns-updown $builddir/... in my t_client tests (still works, and correctly still requires script-security). A brief stare at the code also looks reasonable. The message "I am going to r

[Openvpn-devel] [M] Change in openvpn[master]: run forced --dns-updown without --script-security

2025-06-28 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1065?usp=email ) Change subject: run forced --dns-updown without --script-security .. run forced --dns-updown without --script-security Due to a shortcut

[Openvpn-devel] [M] Change in openvpn[master]: run forced --dns-updown without --script-security

2025-06-28 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#4) to the change originally created by d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/1065?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: run forced --dns-updown without --script-security

[Openvpn-devel] [PATCH applied] Re: dns: create NRPT registry key if it doesn't exist

2025-06-28 Thread Gert Doering
I have not tested this beyond "does it compile on a MinGW buildhost" (it does), and "what does this function do?" (open a registry key if it exists, and create a new key if it doesn't exist yet) - so this all seems to make sense, and Lev confirms that it does what it wants to achieve ;-) Your patc

[Openvpn-devel] [XS] Change in openvpn[master]: dns: create NRPT registry key if it doesn't exist

2025-06-28 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1069?usp=email ) Change subject: dns: create NRPT registry key if it doesn't exist .. dns: create NRPT registry key if it doesn't exist Windows 2019 Serve

[Openvpn-devel] [XS] Change in openvpn[master]: dns: create NRPT registry key if it doesn't exist

2025-06-28 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#4) to the change originally created by d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/1069?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by stipa Change subject: dns: create NRPT registry key if it doesn't exist ...