[Openvpn-devel] [M] Change in openvpn[master]: dns: add updown script for macOS

2025-06-21 Thread plaisthos (Code Review)
Attention is currently required from: d12fk, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1062?usp=email ) Change subject: dns: add updown script for macOS .. Patch Set 3:

[Openvpn-devel] [M] Change in openvpn[master]: dns: add updown script for macOS

2025-06-21 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#4) to the change originally created by d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/1062?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: dns: add updown script for macOS

[Openvpn-devel] [PATCH applied] Re: dns: add updown script for macOS

2025-06-21 Thread Gert Doering
I have not tested this myself, just stared a bit at the code if there are surprises lurking ("unquoted eval" and such). Arne has tested "all DNS via VPN" (was broken in v2) and "split DNS" and both work. So here we go, more test reports welcome. Your patch has been applied to the master branch.

[Openvpn-devel] [M] Change in openvpn[master]: dns: add updown script for macOS

2025-06-21 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1062?usp=email ) Change subject: dns: add updown script for macOS .. dns: add updown script for macOS Change-Id: Iade06a8454ccf53668deef61f07217ead8ec6c63

[Openvpn-devel] [PATCH v3] dns: add updown script for macOS

2025-06-21 Thread Gert Doering
From: Heiko Hund Change-Id: Iade06a8454ccf53668deef61f07217ead8ec6c63 Signed-off-by: Heiko Hund Acked-by: Arne Schwabe --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1062 This m