[Openvpn-devel] [PATCH v2] fix typo in haikuos dns-updown script

2025-06-17 Thread Gert Doering
From: Heiko Hund Change-Id: I48cec222d46c67e6620281cd8b2346323b546fcd Signed-off-by: Heiko Hund Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1061 This m

[Openvpn-devel] [XS] Change in openvpn[master]: Preserve socket protocol during float processing

2025-06-17 Thread its_Giaan (Code Review)
Attention is currently required from: flichtenheld, plaisthos, ralf_lici. its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1063?usp=email ) Change subject: Preserve socket protocol during float processing ..

[Openvpn-devel] [XS] Change in openvpn[master]: Preserve socket protocol during float processing

2025-06-17 Thread ralf_lici (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1063?usp=email to review the following change. Change subject: Preserve socket protocol during float processin

[Openvpn-devel] [XS] Change in openvpn[master]: Preserve socket protocol during float processing

2025-06-17 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1063?usp=email ) Change subject: Preserve socket protocol during float processing .. Preserve socket protocol during float processing During a float opera

[Openvpn-devel] [PATCH applied] Re: Preserve socket protocol during float processing

2025-06-17 Thread Gert Doering
Explanation is very reasonable - good catch, "just adding a field to the mroute" was far less trivial than the original patch made us assume. Since it has an +2 from Giaan I have not further tested it, just stared a bit at the change and it makes sense. The server test framework does not currentl

[Openvpn-devel] [XS] Change in openvpn[master]: fix typo in haikuos dns-updown script

2025-06-17 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1061?usp=email to look at the new patch set (#2). The change is no longer submittable: checks~C

[Openvpn-devel] [M] Change in openvpn[master]: dns: add updown script for macOS

2025-06-17 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1062?usp=email to look at the new patch set (#2). The following approvals got outdated and were remove

[Openvpn-devel] [M] Change in openvpn[master]: dns: add updown script for macOS

2025-06-17 Thread plaisthos (Code Review)
Attention is currently required from: d12fk, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1062?usp=email ) Change subject: dns: add updown script for macOS .. Patch Set 1:

[Openvpn-devel] [XS] Change in openvpn[master]: Preserve socket protocol during float processing

2025-06-17 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by ralf_lici. ( http://gerrit.openvpn.net/c/openvpn/+/1063?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by its_Giaan Change subject: Preserve socket protocol during float processing

[Openvpn-devel] [PATCH v1] Preserve socket protocol during float processing

2025-06-17 Thread Gert Doering
From: Ralf Lici During a float operation, we remove the old `mroute` object corresponding to the current multi instance from the hash table and insert a new one. With the introduction of the multi-socket feature, the `mroute` structure gained a `proto` field, which must also be set in the new ins