flichtenheld has abandoned this change. (
http://gerrit.openvpn.net/c/openvpn/+/1031?usp=email )
Change subject: git-pre-commit-uncrustify: Make sure to not run on branches
with clang-format
..
Abandoned
Not the wanted way fo
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1038?usp=email
to review the following change.
Change subject: t_server_null: Test different permutations of --dh
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1037?usp=email
to review the following change.
Change subject: Do not segfault on missing --dh in server config
..
From: Frank Lichtenheld
Change-Id: I0e13595c1057c680e1065eae84ca94b273ed9ca1
Signed-off-by: Frank Lichtenheld
Acked-by: Gert Doering
---
This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1037?usp=email )
Change subject: Do not segfault on missing --dh in server config
.
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/1037?usp=email )
Change subject: Do not segfault on missing --dh in server config
..
Do not segfault on missing --dh in server config
Change-Id: I0e13595c
Apologies.
"The more trivial a patch looks, the more testing it warrants"...
Now *this* patch is rather trivial, and *have* verified that it, indeed,
makes a config "with no --dh in it" work with no segfault.
Your patch has been applied to the master branch.
commit 92b9cb5e0363a1c19b76a5a6e5f36
cron2 has uploaded a new patch set (#2) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1037?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: Do not segfault on missing --dh in server config
.
Attention is currently required from: cron2, flichtenheld, plaisthos.
cron2 has uploaded a new patch set (#3) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1036?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
From: Frank Lichtenheld
This file is apparently over 20 years old and
was never updated besides fixing some obvious
syntax errors with new versions.
So let's just get rid of it. AFAICT the Windows
installer does not use it. Only the
{server,client}.ovpn. And even there, it just uses
the files di
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/1036?usp=email )
Change subject: Delete old sample-windows file and obsolete Windows sample
handling
.
cron2 has uploaded a new patch set (#4) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1036?usp=email )
Change subject: Delete old sample-windows file and obsolete Windows sample
handling
Attention is currently required from: cron2, plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/790?usp=email )
Change subject: Define a .clang-format file for the project
..
Pa
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1036?usp=email
to review the following change.
Change subject: Delete old sample-windows file
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1036?usp=email
to look at the new patch set (#2).
Change subject: Delete old sample-windows file and obsolete Windows sample
handling
.
Out it goes, well done :-) - checked with "make distcheck" if all the
makefile magic agrees (it does).
Your patch has been applied to the master branch.
commit 1b6b1e33ed9646be97110f5cd1f31a8b2ba0dce8
Author: Frank Lichtenheld
Date: Mon Jun 2 17:38:54 2025 +0200
Delete old sample-windows
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/1036?usp=email )
Change subject: Delete old sample-windows file and obsolete Windows sample
handling
..
Delete old sample-windows file and obsolete Window
17 matches
Mail list logo
