[Openvpn-devel] [XS] Change in openvpn[master]: dco_linux: avoid bogus text when netlink message is not parsed

2025-05-23 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1027?usp=email ) Change subject: dco_linux: avoid bogus text when netlink message is not parsed .. dco_linux: avoid bogus text when netlink message is not

[Openvpn-devel] [XS] Change in openvpn[master]: dco_linux: avoid bogus text when netlink message is not parsed

2025-05-23 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#4) to the change originally created by ordex. ( http://gerrit.openvpn.net/c/openvpn/+/1027?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: dco_linux: avoid bogus text when netlink message is not parse

[Openvpn-devel] [PATCH applied] Re: dco_linux: avoid bogus text when netlink message is not parsed

2025-05-23 Thread Gert Doering
"Because it makes sense" :-) - this is one of the messages we can really live without in the log (and *if* there is something to report, the platform specific layer do so). Your patch has been applied to the master branch. commit 4a48841da2d4179a96348994f841661ec9e5ce1d Author: Antonio Quartulli

[Openvpn-devel] [M] Change in openvpn[master]: Remove HAVE_EXPORT_KEYING_MATERIAL macro

2025-05-23 Thread cron2 (Code Review)
Attention is currently required from: MaxF, flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1043?usp=email ) Change subject: Remove HAVE_EXPORT_KEYING_MATERIAL macro ..

[Openvpn-devel] [PATCH v3] dco_linux: avoid bogus text when netlink message is not parsed

2025-05-23 Thread Gert Doering
From: Antonio Quartulli We may bail out parsing an incoming DCO message because it may concern a different interface. In that case we print the following debug messages: dco_do_read ovpn-dco: ignoring message (type=5) for foreign ifindex 313 process_incoming_dco: received message of

[Openvpn-devel] [M] Change in openvpn[master]: Remove HAVE_EXPORT_KEYING_MATERIAL macro

2025-05-23 Thread flichtenheld (Code Review)
Attention is currently required from: MaxF, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1043?usp=email ) Change subject: Remove HAVE_EXPORT_KEYING_MATERIAL macro .. Patch

[Openvpn-devel] [XS] Change in openvpn[master]: dco_linux: avoid bogus text when netlink message is not parsed

2025-05-23 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1027?usp=email ) Change subject: dco_linux: avoid bogus text when netlink message is not parsed

[Openvpn-devel] [XS] Change in openvpn[master]: dco_linux: avoid bogus text when netlink message is not parsed

2025-05-23 Thread ordex (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1027?usp=email ) Change subject: dco_linux: avoid bogus text when netlink message is not parsed

[Openvpn-devel] [XS] Change in openvpn[master]: dco_linux: avoid bogus text when netlink message is not parsed

2025-05-23 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1027?usp=email to look at the new patch set (#3). Change subject: dco_linux: avoid bogus text

[Openvpn-devel] [M] Change in openvpn[master]: Remove HAVE_EXPORT_KEYING_MATERIAL macro

2025-05-23 Thread MaxF (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1043?usp=email ) Change subject: Remove HAVE_EXPORT_KEYING_MATERIAL macro ..

[Openvpn-devel] [M] Change in openvpn[master]: Remove HAVE_EXPORT_KEYING_MATERIAL macro

2025-05-23 Thread cron2 (Code Review)
Attention is currently required from: MaxF, flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1043?usp=email ) Change subject: Remove HAVE_EXPORT_KEYING_MATERIAL macro ..

[Openvpn-devel] [M] Change in openvpn[master]: Remove HAVE_EXPORT_KEYING_MATERIAL macro

2025-05-23 Thread plaisthos (Code Review)
Attention is currently required from: MaxF, cron2, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1043?usp=email ) Change subject: Remove HAVE_EXPORT_KEYING_MATERIAL macro ..

[Openvpn-devel] [M] Change in openvpn[master]: Use mbedtls_ssl_export_keying_material()

2025-05-23 Thread plaisthos (Code Review)
Attention is currently required from: MaxF, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1041?usp=email ) Change subject: Use mbedtls_ssl_export_keying_material() .. Patch

[Openvpn-devel] [M] Change in openvpn[master]: Remove HAVE_EXPORT_KEYING_MATERIAL macro

2025-05-23 Thread MaxF (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1043?usp=email ) Change subject: Remove HAVE_EXPORT_KEYING_MATERIAL macro ..

[Openvpn-devel] [M] Change in openvpn[master]: Remove HAVE_EXPORT_KEYING_MATERIAL macro

2025-05-23 Thread MaxF (Code Review)
Attention is currently required from: MaxF, cron2, flichtenheld, plaisthos. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1043?usp=email to look at the new patch set (#2). The following approvals got outdated an

[Openvpn-devel] [M] Change in openvpn[master]: Remove HAVE_EXPORT_KEYING_MATERIAL macro

2025-05-23 Thread flichtenheld (Code Review)
Attention is currently required from: MaxF, cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1043?usp=email ) Change subject: Remove HAVE_EXPORT_KEYING_MATERIAL macro ..

[Openvpn-devel] [S] Change in openvpn[master]: t_server_null: print error when server startup fails

2025-05-23 Thread mattock (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. mattock has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1024?usp=email ) Change subject: t_server_null: print error when server startup fails